Summary: | dev-libs/expat-2.2.1 configure failure with app-shells/dash as /bin/sh | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Hadrien Lacour <hadrien.lacour> |
Component: | Current packages | Assignee: | Sebastian Pipping <sping> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aklhfex, alexander, freedesktop-bugs, karl.j.linden, kfm, remi |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 526268 | ||
Attachments: |
emerge --info
emerge -pqv expat-2.2.1-bashism.patch gentoo-622360-0001.patch gentoo-622360-0002.patch |
Description
Hadrien Lacour
2017-06-20 21:49:07 UTC
Created attachment 477498 [details]
emerge -pqv
Created attachment 477500 [details, diff]
expat-2.2.1-bashism.patch
(In reply to iGentoo from comment #2) > Created attachment 477500 [details, diff] [details, diff] > expat-2.2.1-bashism.patch Well.. it's actually not a bashism. It's a detection code taken from old autoconf that doesn't correctly work with gentoo-patched dash (it should work with vanilla dash). Hi! I'm surprised this never showed up before 2.2.1. If printf(1) is as POSIX as it looks like to me [1] then printf may be a good path. Can you please: * Use %s and get the variables out the format string * Use curly braces for variable names * And take the patch upstream [2] as a pull request or issue with a "git format-patch" style patch attached? Many thanks! Sebastian [1] http://pubs.opengroup.org/onlinepubs/009696799/utilities/printf.html [2] https://github.com/libexpat/libexpat (In reply to Sebastian Pipping from comment #4) > I'm surprised this never showed up before 2.2.1. It's due to eautoreconf. From configure.ac: define([expat_version], ifdef([__gnu__], [esyscmd(conftools/get-version.sh lib/expat.h)], [2.2.x])) Pull request issued: https://github.com/libexpat/libexpat/pull/68 Created attachment 478342 [details, diff]
gentoo-622360-0001.patch
Created attachment 478344 [details, diff]
gentoo-622360-0002.patch
Thanks! commit ed776d4e8f2e1da38a6a058e615943b636a52176 Author: Sebastian Pipping <sping@g.o> Date: Sat Jul 1 13:22:06 2017 +0200 dev-libs/expat: Fix compilation (bug #622360) Package-Manager: Portage-2.3.6, Repoman-2.3.2 dev-libs/expat/expat-2.2.1.ebuild | 1 + dev-libs/expat/files/expat-2.2.1-gentoo-dash.patch | 31 ++++++++++++++++++++++ 2 files changed, 32 insertions(+) https://github.com/gentoo/gentoo/commit/ed776d4e8f2e1da38a6a058e615943b636a52176 |