Bug 621914

Summary:	xdg-utils & fdo-mime eclasses contain duplicate functions
Product:	Gentoo Linux	Reporter:	Michał Górny <mgorny>
Component:	Eclasses	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	normal	CC:	freedesktop-bugs, jstein, qa, tsmksubc
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Michał Górny archtester

2017-06-16 15:46:20 UTC

fdo-mime:

fdo-mime_desktop_database_update
fdo-mime_mime_database_update

xdg-utils:

xdg_desktop_database_update
xdg_mimeinfo_database_update


Funny enough, someone forgot to remove 'fdo-' from eclassdoc when copypasting the code.

So why were the functions copied from one eclass to another? Why is there no clear indication to which of the eclasses is supposed to be used? Why isn't the other deprecated and in process of being removed?

Comment 1 Mart Raudsepp gentoo-dev

2017-06-16 19:47:26 UTC

Read git history for the why, that's why it's there.

Comment 2 Michał Górny archtester

2017-06-16 19:53:10 UTC

So you expect every developer to read git log for both eclasses in order to figure out which eclass to use?

Comment 3 diamond 2017-10-21 15:30:10 UTC

Fix "fdo-xdg_desktop_database_update" name there too:
https://devmanual.gentoo.org/eclass-reference/xdg-utils.eclass/index.html

Comment 4 jospezial 2020-12-17 13:49:49 UTC

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d0230377858f7ff50eb9e7b8075f88a993717b59
fdo-mime.eclass: Remove last-rited eclass

Please close.