Summary: | www-client/chromium-59.0.3071.86: ninja mksnapshot failed with gcc-7 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | fhede <fhede71> |
Component: | Current packages | Assignee: | Chromium Project <chromium> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | anton.kochkov, hendrik, herrtimson, octoploid, orodruinlair |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
URL: | https://bugs.chromium.org/p/chromium/issues/detail?id=691681 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 617524 | ||
Attachments: | build.log |
Description
fhede
2017-06-06 11:03:08 UTC
(In reply to octoploid from comment #2) > Patch: https://github.com/nodejs/node/issues/10388#issuecomment-306790522 The patch is for Chromium 60 and above. But you'll find a patch for older versions in the same github issue as well. (In reply to octoploid from comment #2) > Patch: https://github.com/nodejs/node/issues/10388#issuecomment-306790522 Looks like the nodejs issue is going on since Dec 2016. Since you have a patch (awesome!), why not send it v8 upstream? (In reply to Paweł Hajdan, Jr. from comment #4) > (In reply to octoploid from comment #2) > > Patch: https://github.com/nodejs/node/issues/10388#issuecomment-306790522 > > Looks like the nodejs issue is going on since Dec 2016. > > Since you have a patch (awesome!), why not send it v8 upstream? Because the usual reply you'll get is: »Do we care about gcc?« So I stopped reporting gcc issues. The fix is now upstream: https://github.com/v8/v8/commit/c0f1ff2451b43cbc4b1ae9f668b616173877285a (In reply to octoploid from comment #5) > Because the usual reply you'll get is: »Do we care about gcc?« > So I stopped reporting gcc issues. As indicated in the referenced bug, _reports_ of gcc issues indeed are not treated as priority upstream. However, they are taking patches, as indicated by the one you referenced above. Is the issue addressed now? It is not yet part of the current beta (60.xyz), at least the build of the latest 60.0.3112.50 still fails with that error message. The current dev-release (61.0.3141.7) builds fine with GCC 7.1. At least it does not have that issue, my main build is not finished yet. |