Bug 620948 – app-admin/packagekit-base: Needs elogind support

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Andreas Sturmlechner 2017-06-05 19:15:12 UTC]

...to make KDE Frameworks fully independent of consolekit, see also the following current depgraph:

[ebuild   Rf  #] kde-frameworks/frameworkintegration-5.35.0  USE="appstream*" 
[ebuild  N     ]  app-admin/packagekit-qt-0.9.6 
[ebuild  N     ]   app-admin/packagekit-base-1.0.11  USE="introspection networkmanager nsplugin -command-not-found -connman -cron -systemd -vala"

[Comment 1 Sven Eden 2017-06-05 20:00:57 UTC]

Thank you very much!

I have no idea what "appstream" actually is, so I missed that one completely.

However, I think I'll need a few days for that.

[Comment 2 Sven Eden 2017-06-06 09:07:30 UTC]

Created attachment 475326 [details, diff]
Add support for elogind to packagekit-base

This is the required patch to enable elogind support in packagekit-base

[Comment 3 Sven Eden 2017-06-06 09:08:44 UTC]

Created attachment 475328 [details, diff]
Updated Patch to enable elogind support to the ebuild

This is the diff of the in-tree ebuild and my testing ebuild in seden overlay.

For this to work, sys-auth/elogind must be bumped to 229.4.

[Comment 4 Andreas Sturmlechner 2017-06-06 19:36:47 UTC]

That was fast!

I'd request 2 changes:

- elogind? ( sys-auth/elogind ) # should be >=sys-auth/elogind-229.4
- PATCHES array is not used by the ebuild, so let's adapt to the ebuild style and eapply the patch inside src_prepare (I'd rename to ${P}-elogind.patch) with Gentoo bug # reference

[Comment 5 Sven Eden 2017-06-07 09:16:52 UTC]

Created attachment 475438 [details, diff]
Cleaned up and fixed patch to enable elogind support

This patch makes the #define for including systemd/sd-login.h support even clearer and fixes the patched files paths.

[Comment 6 Sven Eden 2017-06-07 09:18:21 UTC]

Created attachment 475440 [details, diff]
Patch in elogind-support to packagekit-base-1.1.5.ebuild

Point taken, Andreas. I hope these changes are now of good enough quality to present them to the packagekit maintainers. ;-)

[Comment 7 Sven Eden 2017-06-07 14:42:23 UTC]

Created attachment 475470 [details, diff]
Cleaned up and fixed patch to enable elogind support [fixed]

Fixed a missing line to patch config.h.in - this one eventually applies.

[Comment 8 Ettore Di Giacinto (RETIRED) 2017-06-13 16:58:55 UTC]

Thanks for working on this!

I'd prefer to switch to PATCHES anyway, if you don't mind un-doing the work already done :) Aside from that, make it -r1 instead of -r2 (or otherwise i'll handle it myself when i'll work on it)

[Comment 9 Sven Eden 2017-06-13 20:09:04 UTC]

(In reply to Ettore Di Giacinto from comment #8)
> Thanks for working on this!
> 
> I'd prefer to switch to PATCHES anyway, if you don't mind un-doing the work
> already done :) Aside from that, make it -r1 instead of -r2 (or otherwise
> i'll handle it myself when i'll work on it)

Will do, but until tomorrow. ;-)

[Comment 10 Sven Eden 2017-06-14 08:00:49 UTC]

Created attachment 476320 [details, diff]
[reviewed] Patch in elogind-support to packagekit-base-1.1.5.ebuild

reviewed patch to add elogind support to the ebuild.

[Comment 11 Ettore Di Giacinto (RETIRED) 2017-06-17 15:12:11 UTC]

Revision bump in tree now, thanks.

commit ab643f0e8d208aabf36445e546854464e15749c5
Author: Ettore Di Giacinto <[e-mail]>
Date:   Sat Jun 17 16:47:20 2017 +0200

    app-admin/packagekit-base: Revision bump (bug #620948)
    
    Add elogind support. Thanks to Sven Eden <[e-mail]>
    
    Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=620948
    Package-Manager: Portage-2.3.5, Repoman-2.3.2