Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 620764

Summary: dev-lang/spidermonkey-24.2.0-r4 : /.../Intl.cpp:1001:83: error: invalid conversion from 'const jschar* {aka const short unsigned int*}' to 'const UChar* {aka const char16_t*}' [-fpermissive]
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Mozilla Gentoo Team <mozilla>
Status: RESOLVED OBSOLETE    
Severity: normal CC: fturco, luigi.mantellini+gentoo
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: emerge-info.txt
config.log.tbz2
dev-lang:spidermonkey-24.2.0-r4:20170603-194116.log
emerge-history.txt
environment
etc.portage.tbz2
Patch to change jschar to char16_t
Patch to change jschar to char16_t
Patch to change jschar to char16_t
spidermonkey-24-Intl-cpp.patch
spidermonkey-24-Intl-cpp.patch

Description Toralf Förster gentoo-dev 2017-06-04 08:18:47 UTC
x86_64-pc-linux-gnu-g++ -o Intl.o -c  -I./dist/system_wrappers_js -include ./config/gcc_hidden.h -DNO_NSPR_10_SUPPORT -DIMPL_MFBT -DEXPORT_JS_API -DUSE_ZLIB -I./../../mfbt/double-conversion  -I. -I. -I./dist/include  -I/usr/include/nspr      -I. -I./assembler -I./yarr  -fPIC  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Werror=conversion-null -Wsign-compare -Wno-invalid-offsetof -Wcast-align -Werror=terminate -O2 -pipe -march=native -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -pthread -pipe  -DNDEBUG -DTRIMMED  -fno-omit-frame-pointer  -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1   -DMOZILLA_CLIENT -include ./js-confdefs.h -MD -MP -MF .deps/Intl.o.pp  /var/tmp/portage/dev-lang/spidermonkey-24.2.0-r4/work/mozjs-24.2.0/js/src/builtin/Intl.cpp
/var/tmp/portage/dev-lang/spidermonkey-24.2.0-r4/work/mozjs-24.2.0/js/src/builtin/Intl.cpp: In function 'bool intl_CompareStrings(JSContext*, UCollator*, JS::HandleString, JS::HandleString, JS::MutableHandleValue)':
/var/tmp/portage/dev-lang/spidermonkey-24.2.0-r4/work/mozjs-24.2.0/js/src/builtin/Intl.cpp:1001:83: error: invalid conversion from 'const jschar* {aka const short unsigned int*}' to 'const UChar* {aka const char16_t*}' [-fpermissive]
 CollationResult uresult = ucol_strcoll(coll, chars1, length1, chars2, length2);
                                                                              ^
In file included from ./dist/system_wrappers_js/unicode/ucol.h:3:0,

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 13.0-systemd_20170527-174218

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-6.3.0 *

Available Python interpreters, in order of preference:
  [1]   python3.4
  [2]   python3.5 (fallback)
  [3]   python2.7 (fallback)
  [4]   pypy3 (fallback)
Available Ruby profiles:
  [1]   ruby21 (with Rubygems) *
  [2]   ruby22 (with Rubygems)
java-config:
The following VMs are available for generation-2:
Comment 1 Toralf Förster gentoo-dev 2017-06-04 08:18:50 UTC
Created attachment 475148 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2017-06-04 08:18:53 UTC
Created attachment 475150 [details]
config.log.tbz2
Comment 3 Toralf Förster gentoo-dev 2017-06-04 08:18:57 UTC
Created attachment 475152 [details]
dev-lang:spidermonkey-24.2.0-r4:20170603-194116.log
Comment 4 Toralf Förster gentoo-dev 2017-06-04 08:19:01 UTC
Created attachment 475154 [details]
emerge-history.txt
Comment 5 Toralf Förster gentoo-dev 2017-06-04 08:19:04 UTC
Created attachment 475156 [details]
environment
Comment 6 Toralf Förster gentoo-dev 2017-06-04 08:19:07 UTC
Created attachment 475158 [details]
etc.portage.tbz2
Comment 7 Luigi 'Comio' Mantellini 2017-06-20 09:29:54 UTC
Created attachment 477308 [details, diff]
Patch to change jschar to char16_t

I propose the attached patch. The issue is from a strict check on type conversion.
btw, should be solved a better way.
Comment 8 Luigi 'Comio' Mantellini 2017-06-20 09:30:41 UTC
Created attachment 477310 [details, diff]
Patch to change jschar to char16_t
Comment 9 Luigi 'Comio' Mantellini 2017-06-20 09:51:32 UTC
Created attachment 477312 [details, diff]
Patch to change jschar to char16_t
Comment 10 Luigi 'Comio' Mantellini 2017-06-25 09:42:40 UTC
Created attachment 477936 [details, diff]
spidermonkey-24-Intl-cpp.patch

Add explicit casts where need.
Comment 11 Luigi 'Comio' Mantellini 2017-06-25 09:51:25 UTC
Created attachment 477940 [details, diff]
spidermonkey-24-Intl-cpp.patch

Fix patching root.
Comment 12 Jory A. Pratt gentoo-dev 2017-06-26 12:12:06 UTC
Please do not add us to the CC list when the bug is already assigned to us.
Comment 13 Jory A. Pratt gentoo-dev 2017-08-26 17:55:36 UTC
If you feel I have closed your bug and it is still a current issue, please reopen and update it completely. We will not work bugs that have no ebuild in tree any longer or can not be reproduced with a current system.

Thank You for your support and understanding
The Mozilla Team