Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 620546

Summary: app-office/abiword: oversized file(s)
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 620650    

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-06-03 21:13:19 UTC
The package includes file(s) larger than 20 KiB in FILESDIR. Please move them to SRC_URI (or remove).

"files/abiword-3.0.0-librevenge.patch" exceeds 20k in size; 37.7 KiB total
Comment 1 causality 2017-09-06 03:33:16 UTC
I'll freely admit that I don't fully understand the significance of having such a cut-off.  I can see why a guideline would be desirable but I don't see why it must be a hard rule.

In that spirit of "what-if?", I wonder why that 20kb limit could not be increased.

For how long has it been 20kb, and how much has generally available bandwidth and storage improved since then?
<br><br>0
Just how critical is it that FILESDIR have no files greater than 20kb?  Has widespread system breakage been documented because of these oversized files?  Do embedded systems direly need these same packages with no alternatives?

What is the scope of the problem that this 20kb limit was intended to solve?  Is it aesthetic, technical, or something else?  Before this rule should be vigorously enforced it should first be well-reasoned.
Comment 2 Larry the Git Cow gentoo-dev 2017-12-08 18:47:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=968910ab62421955ee0abc7eefbdb38270c7a398

commit 968910ab62421955ee0abc7eefbdb38270c7a398
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2017-12-08 18:21:28 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2017-12-08 18:47:10 +0000

    app-office/abiword: [QA] Move patches to a distfile
    
    Closes: https://bugs.gentoo.org/620546

 app-office/abiword/Manifest                        |    3 +-
 app-office/abiword/abiword-3.0.2-r1.ebuild         |   23 +-
 app-office/abiword/abiword-3.0.2.ebuild            |   21 +-
 .../abiword/files/abiword-2.6.0-boolean.patch      |   13 -
 .../abiword/files/abiword-2.8.3-desktop.patch      |   12 -
 .../abiword/files/abiword-3.0.0-librevenge.patch   | 1169 --------------------
 app-office/abiword/files/abiword-3.0.0-libwp.patch |   36 -
 .../abiword-3.0.0-link-grammar-5-second.patch      |   19 -
 .../abiword/files/abiword-3.0.1-fixwps.patch       |   31 -
 .../abiword/files/abiword-3.0.1-libwps-0.4.patch   |   54 -
 ...biword-3.0.2-fix-black-drawing-regression.patch |   54 -
 .../abiword-3.0.2-fix-installing-readme.patch      |   19 -
 .../files/abiword-3.0.2-fix-nullptr-c++98.patch    |   34 -
 13 files changed, 25 insertions(+), 1463 deletions(-)