Bug 620162

Summary:	app-arch/zip[natspec]: option "-k" always enabled
Product:	Gentoo Linux	Reporter:	nE0sIghT <ykonotopov>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	UNCONFIRMED ---
Severity:	normal	CC:	jstein
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/8963
Whiteboard:
Package list:		Runtime testing required:	---

Description nE0sIghT 2017-05-29 17:27:47 UTC

Steps to reproduce:
1. cd /tmp
2. > b
3. ln -s b a
4. zip -y test.zip a

Actual results:
Archive "/tmp/test.zip" contains file b

Expected results:
Archive "/tmp/test.zip" should contains symbolic link a.

Additional info:
This error break AOSP/LineageOS build using Gentoo Linux.

Comment 1 nE0sIghT 2017-05-29 17:42:28 UTC

The reason for this issue is natspec patch.
Maybe we should drop it or add some warning about AOSP?

It's hard to track AOSP build issue to zip app.

Comment 2 SpanKY gentoo-dev

2018-06-25 19:05:13 UTC

the natspec patch exists for a reason.  lets fix it instead of just ignoring it.  the patch is pretty small, so shouldn't be too hard.

Comment 3 nE0sIghT 2018-06-25 20:41:48 UTC

> lets fix it

If it's for me - I'm not interested in fixing this patch since it is against zip specification and works around ancient use-cases.
Since this bug is ignored for year+ I assume "Base system team" is not interested in fixing this also.

Comment 4 Mike Gilbert gentoo-dev

2018-06-25 20:49:18 UTC

Would it suffice to drop the change that sets dosify = 1 by default?

Comment 5 SpanKY gentoo-dev

2018-06-25 22:10:30 UTC

(In reply to nE0sIghT from comment #3)

which is why it's behind a USE flag that isn't turned on by default.  if you don't like/need it, then i'm not sure why you turned it on in the first place.

as for it being "ancient", tell that to people who continue using these zips.  not everyone has joined the UTF8 world, and old compatibility codesets in Windows are in use.

(In reply to Mike Gilbert from comment #4)

at a glance, i think we just need to flip the defaults.

Comment 6 nE0sIghT 2019-12-20 16:31:32 UTC

> Would it suffice to drop the change that sets dosify = 1 by default?

It doesn't works.

Actually this is duplicate of:
https://bugs.gentoo.org/551788
https://bugs.gentoo.org/571676