Bug 619298 – gnome-base/gnome-control-center-3.24.*: Review colord handling

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Mart Raudsepp 2017-05-21 20:01:41 UTC]

The color manager plugin in gnome-settings-daemon was kept optional by ttambet updating patch, but now the gnome-control-center display panel also requires it to do Night Light, and this isn't optional right now. We should review the deps here and maybe just always force colord to simplify things; or make night light optional as well. Night light uses the gnome-settings-daemon[colord] plugin to do what it does afaik (on wayland too).

[Comment 1 Mart Raudsepp 2018-01-08 17:43:17 UTC]

After reviewing, I've found the following:

1) gnome-settings-daemon[colord] (needed by night light) only requires colord, which we depend on in gnome-control-center unconditionally now as well
2) USE=colord in gnome-control-center controls the building of the color setting panel, which additionally depends on colord-gtk (and less importantly libsoup) AND pulls in gnome-color-manager for runtime

As such, I've decided to keep a IUSE=colord for now, but will change gnome-settings-daemon[colord?] to gnome-settings-daemon[colord] to ensure a functioning Night Light with gnome-control-center[-colord].

This will be a problem for those that force disable USE=colord, as gnome-control-center then will want gnome-settings-daemon[colord] still, and the global USE=-colord will disable it for gnome-settings-daemon too (overriding the IUSE default), but... that's on them and they should add it back per-package for gnome-settings-daemon then. It provides functionality other than color calibrated display (red light gamma shifting), hence those that globally disable USE=-colord due to not having a color calibration or not caring about that (there are pre-existing profiles that still help a bit even without full manual calibration), might still want it for gnome-settings-daemon for Night Light.

Alternatively we could remove IUSE=colord from gnome-settings-daemon and always build that plugin, but there may be packages that depend on gnome-settings-daemon and get used outside GNOME otherwise. But I'd be willing to change it to that if that's fine.

[Comment 2 Larry the Git Cow 2018-01-08 18:02:22 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e1643c062300cb1771eb0b0804aed40e73170901

commit e1643c062300cb1771eb0b0804aed40e73170901
Author:     Mart Raudsepp <[e-mail]>
AuthorDate: 2018-01-08 17:52:39 +0000
Commit:     Mart Raudsepp <[e-mail]>
CommitDate: 2018-01-08 17:53:55 +0000

    gnome-base/gnome-control-center: guarantee a working Night Light functionality
    
    Night Light isn't behind USE=colord (not optional), but requires
    gnome-settings-daemon[colord], so unconditionally depend on that.
    
    Raise cups dep to 1.7 while here, as it uses an enum constant introduced there
    and we don't backport the fix for that from gnome-3-24 branch. No practical
    difference, as there is no such old version in-tree anymore.
    
    Closes: https://bugs.gentoo.org/619298
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 .../gnome-control-center/gnome-control-center-3.24.3.ebuild       | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)