Bug 61927 – app-admin/grubconf-0.5.1 (R)DEPEND fix

• Product: Gentoo Linux
• Status: RESOLVED TEST-REQUEST

[Description tklauser 2004-08-27 07:57:57 UTC]

In app-admin/grubconfig-0.5.1 (0.4 and 0.5 too) sys-boot/grub stand in DEPEND, not in REDEPEND. It runs but I think it's more correct to have it in RDEPEND because certainly grub is needed to run grubconfig ;)
Also fixed 

emake 

in src_compile() to 

emake || die "Install failed"

Patch and new ebuild attached

[Comment 1 tklauser 2004-08-27 07:59:02 UTC]

Created attachment 38308 [details, diff]
Patch to fix (R)DEPEND and emake

[Comment 2 tklauser 2004-08-27 07:59:30 UTC]

Created attachment 38310 [details]
The new ebuild with patch applied

[Comment 3 tklauser 2004-08-27 08:01:59 UTC]

Sorry. I mean grubconf not gruconfig

[Comment 4 Robert Moss (RETIRED) 2004-08-27 19:07:28 UTC]

To be honest, this is probably still wrong. I've just been testing grubconf on amd64 and it works great; the problem here is that amd64 users who don't use multilib, plus x86 users who don't want to compile their own grub, will instead need this dependency to be on grub-static. I'm not too au fait with "or" dependencies yet, but I'll have a look see what I can find in the tree and perhaps copy what someone else has done. In the meantime, if you can come up with a way to make this dependency "grub or grub-static" without pulling in grub when grub-static is installed, then feel free to post a new ebuild patch - it would be much appreciated.

[Comment 5 tklauser 2004-08-28 01:19:34 UTC]

Maybe we could introduce something like

PROVIDES="virtual/grub"

in sys-boot/grub and sys-boot/grub-static and then have "virtual/grub" in (R)DEPEND instead of app-admin/grubconf

How about that?

[Comment 6 tklauser 2004-08-28 01:28:41 UTC]

Another possibility would be to introduce an internal (or maybe external) USE flag grub-static an then have something like

grub-static? (sys-boot/grub-static)
!grub-static (sys-boot/grub)

in (R)DEPEND

What do you think is better?

[Comment 7 Robert Moss (RETIRED) 2004-08-31 09:28:36 UTC]

I really don't know which is better. When I get back from Birmingham (I'm here on business until Sunday) I'll look into this one more closely to see if anyone else has come across a similar issue before.

[Comment 8 Robert Moss (RETIRED) 2004-09-08 10:23:48 UTC]

Okay, the fix is quite simple; I'll implement it after the England match ;-p

[Comment 9 Robert Moss (RETIRED) 2004-09-12 09:28:54 UTC]

Oops, I forgot - fixed in CVS, please test.