Summary: | dev-qt/qtwebkit-5.7.1:5 fails to build with ICU >=59 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis <arfrever.fta> |
Component: | Current packages | Assignee: | Qt Bug Alias <qt> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | chewi, fturco, josef64, toralf, xaviermiller |
Priority: | Normal | Keywords: | PATCH, UPSTREAM |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
URL: | https://codereview.qt-project.org/193548 | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=618764 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 618636 | ||
Attachments: |
qtwebkit-5.7.1.log
qtwebkit-5.7.1-icu-59.patch upstream patch |
Description
Arfrever Frehtes Taifersar Arahesis
2017-05-16 11:29:26 UTC
Created attachment 472774 [details]
qtwebkit-5.7.1.log
Created attachment 472778 [details, diff]
qtwebkit-5.7.1-icu-59.patch
This patch is maybe compatible with versions of ICU not using char16_t as UChar, but it was not tested with them.
*** Bug 619768 has been marked as a duplicate of this bug. *** (In reply to Arfrever Frehtes Taifersar Arahesis from comment #2) FWIW fails with gcc-6.3.0 too at plasma_20170527-174630 *** Bug 621386 has been marked as a duplicate of this bug. *** Created attachment 476010 [details, diff]
upstream patch
Here's the patch from the upstream review (patchset 4). I can confirm that it applies to 5.7.1 and builds fine with ICU 59. Runtime testing will follow.
The patch worked, thanks! Upstream fix: https://code.qt.io/cgit/qt/qtwebkit.git/commit/?id=bf172ae289a1348842005a9421797970f9b72060 Upstream patch backported to 5.6.2 and 5.7.1. Thanks everyone! https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c7a13c359ac5a60881c2f45e4a2e544f8a477841 |