| Summary: | net-libs/loudmouth-1.5.3 fails to compile with sys-devel/gcc-7.1.0-r1 lm-sasl.c:532:32: error: comparison between pointer and zero character constant [-Werror=pointer-compare] | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Alpha Bravo <aos> |
| Component: | Current packages | Assignee: | Wolfram Schlich (RETIRED) <wschlich> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | anton.kochkov, jstein, plevine457, toralf |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/mcabber/loudmouth/pull/31 | ||
| See Also: |
https://github.com/mcabber/loudmouth/issues/30 https://github.com/gentoo/gentoo/pull/7619 https://bugs.gentoo.org/show_bug.cgi?id=653156 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 617524 | ||
| Attachments: |
emerge --info
build.log build.log Patch according to upstream fixed ebuild to include the patch (attachment 472662) |
||
Created attachment 472464 [details]
build.log
Created attachment 472486 [details]
build.log
Fix (cf. https://github.com/mcabber/loudmouth/pull/31/files#diff-78b98fe25577194d06bdb8e3f40946a1): loudmouth/lm-sasl.c @@ -529,7 +529,7 @@ sasl_md5_prepare_response (LmSASL *sasl, GHashTable *challenge) } nonce = g_hash_table_lookup (challenge, "nonce"); - if (nonce == NULL || nonce == '\0') { + if (nonce == NULL || nonce[0] == '\0') { g_log (LM_LOG_DOMAIN, LM_LOG_LEVEL_SASL, "%s: server didn't provide a nonce in the challenge", G_STRFUNC); Created attachment 472662 [details, diff]
Patch according to upstream
Created attachment 472664 [details] fixed ebuild to include the patch (attachment 472662 [details, diff]) *** Bug 638498 has been marked as a duplicate of this bug. *** *** Bug 649896 has been marked as a duplicate of this bug. *** Hi, This is the same with gcc-7.3.0. Regards, Sarah The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b5609fa27ea0e940719fa9b89302552fa43699e5 commit b5609fa27ea0e940719fa9b89302552fa43699e5 Author: Peter Levine <plevine457@gmail.com> AuthorDate: 2018-03-26 05:25:59 +0000 Commit: Pacho Ramos <pacho@gentoo.org> CommitDate: 2018-04-14 15:59:02 +0000 net-libs/loudmouth: Fix building with GCC-7 Bug: https://bugs.gentoo.org/618330 Closes: https://bugs.gentoo.org/618330 Package-Manager: Portage-2.3.16, Repoman-2.3.6 .../loudmouth/files/loudmouth-1.5.3-gcc7.patch | 25 ++++++++++++++++++++++ net-libs/loudmouth/loudmouth-1.5.3.ebuild | 3 ++- 2 files changed, 27 insertions(+), 1 deletion(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b5609fa27ea0e940719fa9b89302552fa43699e5 commit b5609fa27ea0e940719fa9b89302552fa43699e5 Author: Peter Levine <plevine457@gmail.com> AuthorDate: 2018-03-26 05:25:59 +0000 Commit: Pacho Ramos <pacho@gentoo.org> CommitDate: 2018-04-14 15:59:02 +0000 net-libs/loudmouth: Fix building with GCC-7 Bug: https://bugs.gentoo.org/618330 Closes: https://bugs.gentoo.org/618330 Package-Manager: Portage-2.3.16, Repoman-2.3.6 .../loudmouth/files/loudmouth-1.5.3-gcc7.patch | 25 ++++++++++++++++++++++ net-libs/loudmouth/loudmouth-1.5.3.ebuild | 3 ++- 2 files changed, 27 insertions(+), 1 deletion(-)} Thanks, this worked for me now! Regards, Sarah |
Created attachment 472462 [details] emerge --info net-libs/loudmouth-1.5.3 fails to compile with sys-devel/gcc-7.1.0-r1 lm-sasl.c: In function 'sasl_md5_prepare_response': lm-sasl.c:532:32: error: comparison between pointer and zero character constant [-Werror=pointer-compare] if (nonce == NULL || nonce == '\0') { ^~