| Summary: | sys-auth/oath-toolkit-2.6.2 with sys-devel/gcc:7 - In file included from parse-duration.c:30:0: intprops.h:234:34: error: expected ')' before '(' token | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Francisco J. Vazquez <dv> |
| Component: | Current packages | Assignee: | Robin Johnson <robbat2> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jouni.kosonen, mark+gentoobugs, plevine457, slyfox, sysadmin, tsjk |
| Priority: | Normal | Keywords: | TESTFAILURE |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/7618 | ||
| Whiteboard: | ~arch only | ||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 617524 | ||
| Attachments: |
patch for oath-toolkit-2.6.2
oath-toolkit-2.6.2-fix-build-with-gcc7.patch previous patch plus libpskc emerge-info.txt emerge-history.txt environment etc.portage.tbz2 logs.tbz2 sys-auth:oath-toolkit-2.6.2:20180504-090507.log temp.tbz2 build.log (ppc64, 2.6.2) |
||
Created attachment 472266 [details, diff]
patch for oath-toolkit-2.6.2
Created attachment 507024 [details, diff]
oath-toolkit-2.6.2-fix-build-with-gcc7.patch
I took the liberty of reformatting the patch so that it can be passed to epatch directly, as /etc/portage/patches/sys-auth/oath-toolkit-2.6.2/oath-toolkit-2.6.2-fix-build-with-gcc7.patch for instance.
Created attachment 517210 [details, diff]
previous patch plus libpskc
I improved the patch to also include libpskc/gl/intprops.h
Now it builds for USE=pskc too.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c5757e21c174721dad7cedcf5a7a6642da4e1446 commit c5757e21c174721dad7cedcf5a7a6642da4e1446 Author: Peter Levine <plevine457@gmail.com> AuthorDate: 2018-03-26 02:52:17 +0000 Commit: Robin H. Johnson <robbat2@gentoo.org> CommitDate: 2018-03-26 19:14:39 +0000 sys-auth/oath-toolkit: Fix building with GCC-7 Bug: https://bugs.gentoo.org/618100 Closes: https://github.com/gentoo/gentoo/pull/7618 Package-Manager: Portage-2.3.16, Repoman-2.3.6 (cherry picked from commit 99a631bb82f619d2553354ca5a0cdf535d4d018b) Signed-off-by: Robin H. Johnson <robbat2@gentoo.org> .../files/oath-toolkit-2.6.2-gcc7.patch | 80 ++++++++++++++++++++++ sys-auth/oath-toolkit/oath-toolkit-2.6.2.ebuild | 5 +- 2 files changed, 84 insertions(+), 1 deletion(-)} got at the unstable amd64 chroot image 17.0-systemd_abi32+64-test_20180501-232814 this : intprops.h:234:34: error: expected ) before ( token Created attachment 529732 [details]
emerge-info.txt
Created attachment 529734 [details]
emerge-history.txt
Created attachment 529736 [details]
environment
Created attachment 529738 [details]
etc.portage.tbz2
Created attachment 529740 [details]
logs.tbz2
Created attachment 529742 [details]
sys-auth:oath-toolkit-2.6.2:20180504-090507.log
Created attachment 529744 [details]
temp.tbz2
For me, the attached patches fail to apply (when just put in /etc/portage/patches), and the emerge just bails out. Am I missing something? I missed that portage had been extended with a patch. But that patch doesn't seem to solve the problem anyway. However, removing the patch in portage and using the one at https://gitlab.com/oath-toolkit/oath-toolkit/commit/2fffce2a471f74a585939c84cce16ef3015e5d3d.diff enables successful merging of it for me (with gcc7, yes). (In reply to Tamas Jantvik from comment #14) > I missed that portage had been extended with a patch. But that patch doesn't > seem to solve the problem anyway. However, removing the patch in portage and > using the one at > https://gitlab.com/oath-toolkit/oath-toolkit/commit/ > 2fffce2a471f74a585939c84cce16ef3015e5d3d.diff enables successful merging of > it for me (with gcc7, yes). Thanks for noting that! For me sys-auth/oath-toolkit-2.6.2 came up for rebuild after bumping to dev-libs/icu-62.1 in @preserved-rebuild where it failed with this error. Replacing the oath-toolkit-2.6.2-gcc7.patch with the one you linked worked. On a related note, sys-auth/oath-toolkit[pskc] seems to have an undeclared slotted dependency on dev-libs/icu. Created attachment 554986 [details]
build.log (ppc64, 2.6.2)
Happens on ppc64 too, despite the oath-toolkit-2.6.2-gcc7.patch.
oath-toolkit has a few copies of intprops.h. I think we'll need to fix all of them. oath-toolkit-2.6.2 # sha1sum `find -name intprops.h` 80f75f3e828b3ec5ac5d6db7c99aaa9b118e325f ./libpskc/gl/intprops.h 79d7d4ea576e675edb7f3c3e79af076c7fdfae7c ./oathtool/gl/intprops.h b8f789d2d97263fcd6c6cecd4d88c0113b68c0ec ./pskctool/gl/intprops.h b8f789d2d97263fcd6c6cecd4d88c0113b68c0ec ./liboath/gl/tests/intprops.h The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=01df74eb09be15e0bc046525233de8c0a2a48f1d commit 01df74eb09be15e0bc046525233de8c0a2a48f1d Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2019-02-02 11:57:47 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2019-02-02 11:58:06 +0000 sys-auth/oath-toolkit: fix USE=pskc for gcc-7, bug #618100 Propagate gcc-7 fix to all copies of intprops.h. Reported-by: Francisco J. Vazquez Closes: https://bugs.gentoo.org/618100 Package-Manager: Portage-2.3.59, Repoman-2.3.12 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> sys-auth/oath-toolkit/oath-toolkit-2.6.2.ebuild | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) Works fine now, thanks! |
In file included from parse-duration.c:30:0: intprops.h:234:34: error: expected ')' before '(' token __builtin_add_overflow (a, b, (__typeof__ ((a) + (b)) *) 0) ^ It's the same problem as #617538. The same patch works here, but has to be applied to all intprops.h copies: libpskc/gl/intprops.h oathtool/gl/intprops.h pskctool/gl/intprops.h liboath/gl/tests/intprops.h Reproducible: Always