Bug 616718 – profiles/package.mask: QA warnings due to dev-db/redis masks

• Product: Gentoo Linux
• Status: RESOLVED OBSOLETE

[Description Andreas Wiese 2017-04-27 09:57:24 UTC]

During operation, cave reports QA warnings about too many tokens in profiles/package.mask caused by comments placed on the same line as masks, which is not allowed:

charlotte:~# cave report
cave@1493286866: [QA e.mask.malformed] In thread ID '6382':
  ... In program cave report:
  ... When generating masks for ID 'app-accessibility/at-spi2-atk-2.22.0:2::gentoo':
  ... When loading repository masks for 'gentoo':
  ... When adding profile configuration file '/var/db/paludis/repositories/gentoo/profiles/package.mask':
  ... Line '=dev-db/redis-3.2.5-r2 # except somebody bumped it out of pattern' in '/var/db/paludis/repositories/gentoo/profiles/package.mask' contains multiple tokens; ignoring
cave@1493286866: [QA e.mask.malformed] (same context) Line '=dev-db/redis-3.2.6-r2 # except somebody bumped it out of pattern' in '/var/db/paludis/repositories/gentoo/profiles/package.mask'
contains multiple tokens; ignoring
cave@1493286871: [QA e.mask.malformed] In thread ID '6382':
  ... In program cave report:
  ... When generating masks for ID 'virtual/linux-sources-9998:0::meterriblerepo':
  ... When loading repository masks for 'meterriblerepo':
  ... When adding profile configuration file '/var/db/paludis/repositories/gentoo/profiles/package.mask':
  ... Line '=dev-db/redis-3.2.5-r2 # except somebody bumped it out of pattern' in '/var/db/paludis/repositories/gentoo/profiles/package.mask' contains multiple tokens; ignoring
cave@1493286871: [QA e.mask.malformed] (same context) Line '=dev-db/redis-3.2.6-r2 # except somebody bumped it out of pattern' in '/var/db/paludis/repositories/gentoo/profiles/package.mask'
contains multiple tokens; ignoring
cave report  8.68s user 0.43s system 99% cpu 9.120 total
charlotte:~#

The offending lines are around line 375:

# Robin H. Johnson <[e-mail]> (18 Nov 2016)
# Depends on slotted lua,
# odd revisions are slotted lua,
# even revisions are unslotted lua
=dev-db/redis-3.2.5-r1
=dev-db/redis-3.2.5-r2 # except somebody bumped it out of pattern
=dev-db/redis-3.2.5-r5
=dev-db/redis-3.2.6-r1
=dev-db/redis-3.2.6-r2 # except somebody bumped it out of pattern
=dev-db/redis-3.2.6-r5
=dev-db/redis-3.2.8-r1

[Comment 1 kapsh 2017-05-06 11:01:34 UTC]

                     Format:
                     - comment lines begin with # (no inline comments)
                     - one DEPEND atom per line

[Comment 2 fkater 2017-05-10 21:16:12 UTC]

+1

A lot of collegues get confused here and try to fix things, just caused by the strange output.

Please move the inline comment in package.mask to separate lines, that's all.

[Comment 3 Andreas Wiese 2017-05-15 14:51:57 UTC]

Created attachment 472660 [details, diff]
fix for replacing inline comment with comment on previous line

Come ooon, guys, it's not that hard but awfully annoying.  Patch attached for fixing this in even less than half a minute.

[Comment 4 Andreas Wiese 2017-06-05 15:53:34 UTC]

Apparently this was (finally…) silently fixed by cleanup after removal of old versions.