Summary: | sys-fs/eudev-3.2.2 creates links with wrong names under /dev/disk/by-id/ | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sven E. <dark> |
Component: | Current packages | Assignee: | eudev team <eudev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Fix for WWN links under /dev/disk/by-id |
Description
Sven E.
2017-04-26 04:06:07 UTC
(In reply to Sven E. from comment #1) > Reference: > https://cgit.freedesktop.org/systemd/systemd/commit/src/udev/ata_id/ata_id. > c?id=ec62e858734a66130f68d036c55c2050bde1e52e Thanks, did you test that this fixes the issue? (In reply to Anthony Basile from comment #2) > (In reply to Sven E. from comment #1) > > Reference: > > https://cgit.freedesktop.org/systemd/systemd/commit/src/udev/ata_id/ata_id. > > c?id=ec62e858734a66130f68d036c55c2050bde1e52e > > Thanks, did you test that this fixes the issue? Not yet. Didn't have time to modify the ebuild to apply the patch. But since it was a change to ata_id at the time when the problem disappeared and it changes the printf formatting, I thought it must have been the right one. Additionally, the commit has: https://bugzilla.redhat.com/show_bug.cgi?id=1227503 as reference Which describes ecatly the bug I am seeing, it seems the (wrong) output is a decimal representation of the hex WWN. Darn, now that I looked at it again, there's more to it, it seems this change only fixes the decimal (instead of correct hex) output, but the words are still in the wrong order. If it is okay for you, I'll look into this later today or tomorrow. Created attachment 470986 [details, diff]
Fix for WWN links under /dev/disk/by-id
Patch fixing up ata_id's WWN output on which udev build it's /dev/disk/by-id/ links. Includes extra rules to keep the old faulty wwn links in place to make sure people using them don't run into problems.
Patch is based on: https://github.com/systemd/systemd/pull/651/commits/01f61d331bb5038f0c877ac03c54333328b6ea28 and https://github.com/keszybz/systemd/commit/c505b456a6b23ffe1d11b597f4aa82f5bead961f With proposed patch ata_id outputs: ID_WWN=0x50014ee1013ca11a <- the result we really wanted. ID_WWN_WITH_EXTENSION=0x50014ee1013ca11a ID_WWN_WITH_EXTENSION_REVERSED_DO_NOT_USE=0x11608592348033929217x <- old broken name based on decimal representation (In reply to Sven E. from comment #6) > With proposed patch ata_id outputs: > ID_WWN=0x50014ee1013ca11a <- the result we really wanted. > ID_WWN_WITH_EXTENSION=0x50014ee1013ca11a > ID_WWN_WITH_EXTENSION_REVERSED_DO_NOT_USE=0x11608592348033929217x <- old > broken name based on decimal representation the patch is in with eudev-3.2.2-r1. i have yet to add it to the git repo. let me know if there are any issues. it passed a compile test. (In reply to Sven E. from comment #4) > Created attachment 470986 [details, diff] [details, diff] > Fix for WWN links under /dev/disk/by-id > > Patch fixing up ata_id's WWN output on which udev build it's > /dev/disk/by-id/ links. Includes extra rules to keep the old faulty wwn > links in place to make sure people using them don't run into problems. I used upstream's patch to fix this in eudev-3.2.3. Can you test that out and see if the problem is fixed there. (In reply to Anthony Basile from comment #8) > (In reply to Sven E. from comment #4) > > Created attachment 470986 [details, diff] [details, diff] [details, diff] > > Fix for WWN links under /dev/disk/by-id > > > > Patch fixing up ata_id's WWN output on which udev build it's > > /dev/disk/by-id/ links. Includes extra rules to keep the old faulty wwn > > links in place to make sure people using them don't run into problems. > > I used upstream's patch to fix this in eudev-3.2.3. Can you test that out > and see if the problem is fixed there. I'm a little confused, aren't you part of the eudev upstream team? Anyhow, the ouput of ata_id seems correct and the links in /dev/disk/by-id/ look good too. (In reply to Sven E. from comment #9) > (In reply to Anthony Basile from comment #8) > > (In reply to Sven E. from comment #4) > > > Created attachment 470986 [details, diff] [details, diff] [details, diff] [details, diff] > > > Fix for WWN links under /dev/disk/by-id > > > > > > Patch fixing up ata_id's WWN output on which udev build it's > > > /dev/disk/by-id/ links. Includes extra rules to keep the old faulty wwn > > > links in place to make sure people using them don't run into problems. > > > > I used upstream's patch to fix this in eudev-3.2.3. Can you test that out > > and see if the problem is fixed there. > > I'm a little confused, aren't you part of the eudev upstream team? I meant systemd's commit. So when *I* say upstream I mean systemd ;) > > Anyhow, the ouput of ata_id seems correct and the links in /dev/disk/by-id/ > look good too. Good. Note that 3.2.3 is currently masked because I got a report of a boot failure. I'm not sure its eudev's fault yet, but to be safe, I can leave it in the tree masked for a while until I'm convinced its okay. (In reply to Anthony Basile from comment #10) > I meant systemd's commit. So when *I* say upstream I mean systemd ;) > Ah, makes sense ;-). > > > > Anyhow, the ouput of ata_id seems correct and the links in /dev/disk/by-id/ > > look good too. > > Good. Note that 3.2.3 is currently masked because I got a report of a boot > failure. I'm not sure its eudev's fault yet, but to be safe, I can leave it > in the tree masked for a while until I'm convinced its okay. Fine with me, I had the opportunity to reboot the system and I can definately state that all links for WWNS of (S)ATA-drives are created correctly and as expected. Thanks for your effort. |