Bug 615706

Summary:	<dev-perl/Perl-Critic-1.130.0 fails tests without '.' in @INC ( Can't locate blib/script/perlcritic in @INC )
Product:	Gentoo Linux	Reporter:	Kent Fredric (IRC: kent\n) (RETIRED) <kentnl>
Component:	Current packages	Assignee:	Gentoo Perl team <perl>
Status:	RESOLVED FIXED
Severity:	minor	Keywords:	TESTFAILURE
Priority:	Low
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/Perl-Critic/Perl-Critic/issues/738
Whiteboard:	stabilize 1.130.0 after 2018-01-23
Package list:		Runtime testing required:	---
Bug Depends on:	648584
Bug Blocks:	612408

Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev

2017-04-16 03:26:41 UTC

t/07_perlcritic.t ............................. 1/1
#   Failed test 'require 'blib/script/perlcritic';'
#   at t/07_perlcritic.t line 22.
#     Tried to require ''blib/script/perlcritic''.
#     Error:  Can't locate blib/script/perlcritic in @INC (@INC contains: /var/tmp/portage/dev-perl/Perl-Critic-1.123/work/Perl-Critic-1.123/blib/lib /var/tmp/portage/dev-perl/Perl-Critic-1.123/work/Perl-Critic-1.123/blib/arch inc /etc/perl /usr/local/lib64/perl5/5.25.11/x86_64-linux /usr/local/lib64/perl5/5.25.11 /usr/lib64/perl5/vendor_perl/5.25.11/x86_64-linux /usr/lib64/perl5/vendor_perl/5.25.11 /usr/local/lib64/perl5 /usr/lib64/perl5/vendor_perl/5.25.11 /usr/lib64/perl5/vendor_perl/5.22.3 /usr/lib64/perl5/vendor_perl /usr/lib64/perl5/5.25.11/x86_64-linux /usr/lib64/perl5/5.25.11) at (eval 6) line 2.
# Looks like you failed 1 test of 1.
t/07_perlcritic.t ............................. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests
t/08_document.t ............................... ok  
t/09_theme.t .................................. ok  
t/10_user_profile.t ........................... ok  
t/11_policy_factory.t ......................... ok

Comment 1 Larry the Git Cow gentoo-dev

2017-12-23 00:23:18 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4170adf97b2a2a5d45df7c903a902524f02062b5

commit 4170adf97b2a2a5d45df7c903a902524f02062b5
Author:     Kent Fredric <kentnl@gentoo.org>
AuthorDate: 2017-12-23 00:22:50 +0000
Commit:     Kent Fredric <kentnl@gentoo.org>
CommitDate: 2017-12-23 00:22:50 +0000

    dev-perl/Perl-Critic: Bump to version 1.130.0 re bug #615706
    
    Upstream:
    - Policies can now be told about modules that export autodie
    - Fix test failures on 5.26 without '.' in @INC
    - Fix showing wrong violation context for elements with blank lines
    - Speed up ProhibitUselessTopic
    - Doc fixes
    
    Bug: https://bugs.gentoo.org/615706
    Package-Manager: Portage-2.3.18, Repoman-2.3.6

 dev-perl/Perl-Critic/Manifest                   |  1 +
 dev-perl/Perl-Critic/Perl-Critic-1.130.0.ebuild | 82 +++++++++++++++++++++++++
 2 files changed, 83 insertions(+)}

Comment 2 Larry the Git Cow gentoo-dev

2018-03-22 06:58:19 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=558b6ec44763d305b7b1f0331b7f5bebc3dca694

commit 558b6ec44763d305b7b1f0331b7f5bebc3dca694
Author:     Kent Fredric <kentnl@gentoo.org>
AuthorDate: 2018-03-22 06:55:02 +0000
Commit:     Kent Fredric <kentnl@gentoo.org>
CommitDate: 2018-03-22 06:58:07 +0000

    dev-perl/Perl-Critic: Cleanup old re bug #615706
    
    Closes: https://bugs.gentoo.org/615706
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 dev-perl/Perl-Critic/Manifest                   |  2 -
 dev-perl/Perl-Critic/Perl-Critic-1.123.ebuild   | 44 -------------
 dev-perl/Perl-Critic/Perl-Critic-1.126.0.ebuild | 82 -------------------------
 3 files changed, 128 deletions(-)