| Summary: | <dev-util/intltool-0.51.0-r2 intltool-update broken on Perl 5.26 ( Unescaped left brace in regex is illegal here ) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Kent Fredric (IRC: kent\n) (RETIRED) <kentnl> |
| Component: | Stabilization | Assignee: | Freedesktop bugs <freedesktop-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kingjon3377 |
| Priority: | Normal | Keywords: | STABLEREQ |
| Version: | unspecified | Flags: | stable-bot:
sanity-check+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://bugs.launchpad.net/intltool/+bug/1696658 | ||
| Whiteboard: | |||
| Package list: |
dev-util/intltool-0.51.0-r2
|
Runtime testing required: | --- |
| Bug Depends on: | |||
| Bug Blocks: | 613764 | ||
Note the cited bug, is of course, incomplete, and the stated patch does *not* fix this problem, because if it did, this problem would already be fixed ( we have it in files/ )
It only fixes *some* of the problem, while leaving others untouched.
Affected Line in 0.51.0-r1:
$sub = $varhash{$2} if defined $varhash{$2} and $varhash{$2} !~ /\${?$2}?/;
That is *literally* in the same screenfull as:
https://github.com/Alexpux/MSYS2-packages/blob/master/intltool/perl-5.22-compatibility.patch#L8
Literally only 7 lines down.
commit 1105187fc65d8bf643e682fcef39620dcfd9326a Author: Andreas K. Hüttel <dilfridge@gentoo.org> Date: Wed Jun 28 00:54:58 2017 +0200 dev-util/intltool: Revision bump for bug 614698 Package-Manager: Portage-2.3.6, Repoman-2.3.2 dev-util/intltool/files/intltool-0.51.0-perl-5.26.patch | 12 ++++++++++++ dev-util/intltool/intltool-0.51.0-r2.ebuild | 30 ++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+) ia64 stable Stable on alpha. arm stable ppc64 stable ppc stable sparc stable (thanks to Rolf Eike Beer) hppa stable amd64 stable x86 stable, closing |
This bug is annoying because its not immediately visible in intltool, tests pass, etc. However, when merging gnome-themes-standard, intltool-update exposes itself as broken: Making check in po make[1]: Entering directory '/var/tmp/portage/x11-themes/gnome-themes-standard-3.22.3/work/gnome-themes-standard-3.22.3/po' INTLTOOL_EXTRACT="/usr/bin/intltool-extract" XGETTEXT="/usr/bin/xgettext" srcdir=. /usr/bin/intltool-update --gettext-package gnome-themes-standard --pot rm -f missing notexist srcdir=. /usr/bin/intltool-update -m Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\${ <-- HERE ?PACKAGE}?/ at /usr/bin/intltool-update line 1071, <CONF> line 98. make[1]: *** [Makefile:152: check] Error 255 make[1]: Leaving directory '/var/tmp/portage/x11-themes/gnome-themes-standard-3.22.3/work/gnome-themes-standard-3.22.3/po' The applicable context being: 1070 # Ignore recursive definitions of variables 1071 $sub = $varhash{$2} if defined $varhash{$2} and $varhash{$2} !~ /\${?$2}?/; 1072 1073 return SubstituteVariable ("$untouched$sub$rest"); Changing line 1071 by adding a \ in that regex: Seems enough to get gnome-themes-standard working, but there are probably many more such mistakes in upstreams code that need fixing.