Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 614608

Summary: targets/desktop/gnome/make.defaults: enable "gnome-shell" USE by default
Product: Gentoo Linux Reporter: Pacho Ramos <pacho>
Component: ProfilesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 635304    

Description Pacho Ramos gentoo-dev 2017-04-04 09:22:20 UTC
I have seen an increasing number of package is setting "gnome-shell" local USEs to enable optional gnome-shell support

In the case of "gnome" profile users, I think we would want to get that enabled by default. What do you think?
Comment 1 Mart Raudsepp gentoo-dev 2017-04-04 10:08:57 UTC
I'm not sure if global makes sense or not (as opposed to e.g IUSE default or via package.use of gnome profile target). Though when looking at the usages, it seems that most are about installing some gnome-shell theme in x11-themes/ packages, for whose benefit it seems appropriate to enable globally to get the gnome-shell theme on gnome profiles.
OTOH, I'm a bit weary of it for a few of the other uses, where it's for compiling and installing a search provider, e.g gnome-terminal. I think it makes sense, just in this specific case the search provider has been a bit crashy in the past, though it has more fixes in 3.24, plus I don't think the crashes actually have any other effect than an entry and core dump to coredumpctl and the specific search provider stopping to work.

My vote would be a slightly hesitant "Yes, lets enable it globally for gnome target"
Comment 2 Pacho Ramos gentoo-dev 2019-04-11 15:40:06 UTC
then, do we enable it finally? :)
Comment 3 Mart Raudsepp gentoo-dev 2023-10-08 12:32:52 UTC
I think lets just go for it, though the only consumers I find with a naive grep are:

gnome-base/gnome-light - This should remain IUSE defaulted as well
x11-terms/gnome-terminal - This is the main beneficiary here
x11-themes/arc-theme - makes sense to go via profile
x11-themes/vertex-theme - same
x11-themes/zuki-themes - same

Given that the USE flag name is gnome-shell with "gnome" in there, I don't see a big problem in just putting it in make.defaults then, though some purists might say it belongs to a list of package.use as it's not a global USE flag, but easy to miss adding new entries to gnome profiles package.use then.
Comment 4 Larry the Git Cow gentoo-dev 2023-10-08 12:58:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1c4989cb3526fcde2cd0ea334e449b6de51cacf8

commit 1c4989cb3526fcde2cd0ea334e449b6de51cacf8
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2023-10-08 12:52:41 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2023-10-08 12:57:43 +0000

    profiles/targets/desktop/gnome: Enable gnome-shell by default
    
    As most users of this profile will expect a full GNOME desktop experience, and
    gnome-shell is a core component for it.
    
    Closes: https://bugs.gentoo.org/614608
    Thanks-to: Mart Raudsepp
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 profiles/targets/desktop/gnome/make.defaults | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)