| Summary: | dev-libs/libdnet exports strlcat() strlcpy() | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jeroen Roovers (RETIRED) <jer> |
| Component: | Current packages | Assignee: | Gentoo Netmon project <netmon> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | bsd+disabled, sam |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: |
https://github.com/ofalk/libdnet/issues/68 https://github.com/ofalk/libdnet/issues/57 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | fragroute-1.2.6-includes.patch | ||
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=de397177f198704042dbfe0499ad1b8813e553f8 commit de397177f198704042dbfe0499ad1b8813e553f8 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-05-16 06:03:50 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-05-16 19:56:37 +0000 dev-libs/libdnet: add 1.16.1 Closes: https://bugs.gentoo.org/612400 Signed-off-by: Sam James <sam@gentoo.org> dev-libs/libdnet/Manifest | 1 + dev-libs/libdnet/libdnet-1.16.1.ebuild | 79 ++++++++++++++++++++++++++++++++++ 2 files changed, 80 insertions(+) |
Created attachment 466784 [details, diff] fragroute-1.2.6-includes.patch Well, I had some fun this morning. I was investigating two warnings in net-analyzer/fragroute-1.2.6: * QA Notice: Package triggers severe warnings which indicate that it * may exhibit random runtime failures. * mod.c:140:4: warning: implicit declaration of function ‘strlcat’ [-Wimplicit-function-declaration] * tun-loop.c:288:2: warning: implicit declaration of function ‘strlcpy’ [-Wimplicit-function-declaration] So I came up with the attached patch that has fragroute use libbsd's strlcat() and strlcpy(), but then found myself puzzling at why --as-needed strips libbsd. It's because the dev-libs/libdnet library (same author as fragroute) helpfully exports both functions! 84: 0000000000008d60 176 FUNC GLOBAL DEFAULT 10 strlcat 151: 0000000000008e20 80 FUNC GLOBAL DEFAULT 10 strlcpy I am not aware of any linking problems or security issues with these duplicated functions, but I assume someone else might be.