Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 612254

Summary: RESTRICT=binchecks handling and binary (non-ELF/executable) checks
Product: Portage Development Reporter: SpanKY <vapier>
Component: Core - Ebuild SupportAssignee: Portage team <dev-portage>
Status: CONFIRMED ---    
Severity: normal CC: gentoo
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=749624
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 835380    

Description SpanKY gentoo-dev 2017-03-10 21:32:06 UTC
while working with a binary package that installs a ton of files, we found that it still continued to install slowly.  turns out it's because pngfix is still run on all the files.

should the pngfix be behind this restrict check as well ?  i'm leaning towards yes ...

--- a/bin/install-qa-check.d/60pngfix
+++ b/bin/install-qa-check.d/60pngfix
@@ -1,6 +1,8 @@
 # Check for issues with PNG files
 
 pngfix_check() {
+   has binchecks ${RESTRICT} && return
+
    local pngfix=$(type -P pngfix)
    if [[ -n ${pngfix} ]] ; then
        local pngout=()
Comment 1 Zac Medico gentoo-dev 2017-03-10 21:48:40 UTC
Yeah, binchecks fits well enough I guess. We could always add RESTRICT="pngfix" later if somebody wanted.