Bug 610376

Summary:	dev-vcs/git-2.11.1 add libsecret USE
Product:	Gentoo Linux	Reporter:	Andreas Fink <finkandreas>
Component:	Current packages	Assignee:	Robin Johnson <robbat2>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	polynomial-c
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=610920
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	ebuild with additional libsecret USE-flag Ebuild replacing libgnome-keyring with libsecret for gnome-keyring USE-flag Unified diff replacing libgnome-keyring with libsecret

Description Andreas Fink 2017-02-21 15:41:29 UTC

Additionally to gnome-keyring it is possible to use libsecret. Attached is the modified ebuild, which adds libsecret support to the ebuild.

Reproducible: Always

Comment 1 Andreas Fink 2017-02-21 15:43:09 UTC

Created attachment 464538 [details]
ebuild with additional libsecret USE-flag

Comment 2 Andreas Fink 2017-02-21 15:56:51 UTC

Created attachment 464542 [details]
Ebuild replacing libgnome-keyring with libsecret for gnome-keyring USE-flag

Similar ebuild but not introducing a new useflag, but replacing libgnome-keyring with libsecret.

Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2017-02-21 16:02:46 UTC

Can you please attach unified diffs of the changes you did to the ebuild?

Comment 4 Andreas Fink 2017-02-21 16:08:24 UTC

Created attachment 464546 [details, diff]
Unified diff replacing libgnome-keyring with libsecret

Comment 5 Robin Johnson archtester

2017-02-21 19:42:32 UTC

is libgnome-keyring obsolete? Wondering why one of the diffs replaced gnome-keyring with libsecret.

Comment 6 Andreas Fink 2017-02-21 21:09:39 UTC

Last commits in the master branch of libgnome-keyring have as commit message, that the module is deprecated and libsecret should be used instead [1].
The advantage of libsecret is that it is supported by gnome-keyring and ksecretservice since it's using the secret service DBus specification.

[1]: https://github.com/GNOME/libgnome-keyring/tree/master/library

Comment 7 Andreas Fink 2017-02-21 21:23:51 UTC

This is also following the style of other ebuilds to depend on libsecret for the gnome-keyring useflag (e.g. pinentry, evince)

Comment 8 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2017-02-25 20:41:25 UTC

commit 48fa0f33ae76bc7b515fda6d2c22d966cb607d62
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Sat Feb 25 21:37:08 2017

    dev-vcs/git: Bump to version 2.12.0

    Replaced gnome-keyring support with libsecret (bug #610376).
    Dropped hppa keyword because libsecret is not keyworded for hppa.

    Package-Manager: Portage-2.3.3, Repoman-2.3.1