Summary: | sci-visualization/qtiplot-0.9.8.9-r3 fails to compile against sip-4.19 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Fabio Rossi <rossi.f> |
Component: | Current packages | Assignee: | Gentoo Science Related Packages <sci> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | PATCH |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 611784 | ||
Attachments: | qtiplot-0.9.8.9-sip-4.19.patch |
Description
Fabio Rossi
2017-02-13 16:11:13 UTC
Created attachment 463652 [details, diff]
qtiplot-0.9.8.9-sip-4.19.patch
Here is the proposed patch which fixes the compilation. Moreover the patch removes the delete statement because it causes a crash with double free or corruption.
Unfortunately, this patch doesn't suffice. I still get In file included from src/scripting/PythonScripting.cpp:61:0: src/scripting/PythonScripting.cpp: In member function 'bool PythonScripting::setQObject(QObject*, const char*, PyObject*)': /var/tmp/portage/sci-visualization/qtiplot-0.9.8.9-r4/work/qtiplot-0.9.8.9/tmp/qtiplot/sipAPIqti.h:2399:75: error: 'sipWrapperType {aka struct _sipWrapperType}' has no member named 'type' ne sipConvertFromInstance(p, wt, t) sipConvertFromType((p), (wt)->type, (t)) ^ src/scripting/PythonScripting.cpp:365:21: note: in expansion of macro 'sipConvertFromInstance' if (klass) pyobj = sipConvertFromInstance(val, klass, NULL); ^~~~~~~~~~~~~~~~~~~~~~ Furthermore, I had to add the following sed instructions to src_prepare sed -i -e's/setFlags(!Qt::ItemIsEditable)/setFlags((Qt::ItemFlags)!Qt::ItemIsEditable)/g' \ qtiplot/src/core/ConfigDialog.cpp qtiplot/src/analysis/dialogs/FitDialog.cpp qtiplot/src/lib/src/ColorMapEditor.cpp sed -i -e's/QComboBox( *false *)/QComboBox/g' \ qtiplot/src/plot2D/dialogs/PlotDialog.cpp qtiplot/src/plot2D/dialogs/LayerDialog.cpp \ qtiplot/src/table/SetColValuesDialog.cpp qtiplot/src/table/TableDialog.cpp \ qtiplot/src/matrix/MatrixValuesDialog.cpp sed -i -e's/PatternBox( *false *)/PatternBox/g' qtiplot/src/plot2D/dialogs/PlotDialog.cpp (In reply to Helmut Jarausch from comment #2) > Unfortunately, this patch doesn't suffice. > > I still get > > In file included from src/scripting/PythonScripting.cpp:61:0: > src/scripting/PythonScripting.cpp: In member function 'bool > PythonScripting::setQObject(QObject*, const char*, PyObject*)': > /var/tmp/portage/sci-visualization/qtiplot-0.9.8.9-r4/work/qtiplot-0.9.8.9/ > tmp/qtiplot/sipAPIqti.h:2399:75: error: 'sipWrapperType {aka struct > _sipWrapperType}' has no member named 'type' > ne sipConvertFromInstance(p, wt, t) sipConvertFromType((p), (wt)->type, > (t)) > ^ > src/scripting/PythonScripting.cpp:365:21: note: in expansion of macro > 'sipConvertFromInstance' > if (klass) pyobj = sipConvertFromInstance(val, klass, NULL); > ^~~~~~~~~~~~~~~~~~~~~~ > Because your problem is not related to this bug, see also #606704. Furthermore you are reporting against qtiplot-0.9.8.9-r4, I'd suggest to open another bug report when you applied both patches (the one here and the other in #606704). Thanks for your contribution, added the patch in commit 68af1bcdec50266f55ffd8cbd32e5522b820935a |