Summary: | app-mobilephone/gammu: automagic dependency on dev-db/unixODBC | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | coyote <viking-coyote> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | np-hardass |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/gammu/gammu/blob/master/CMakeLists.txt#L186 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | ebuild for the last version |
Description
coyote
2017-02-02 11:53:40 UTC
Going to let this sit for a couple of days in case someone wants to handle fixing this. It has no maintainer, and I'd rather not file it into oblivion just yet. Additionally, please feel free to file a pull request to patch this package. Created attachment 465320 [details]
ebuild for the last version
- added odbc USE
- patch for automagic fix will send to upstream
--- CMakeLists.txt 2017-02-25 23:05:05.211461959 +0300 +++ CMakeLists.txt- 2017-02-26 21:30:49.393176711 +0300 @@ -183,7 +183,12 @@ # Packages in sources macro_optional_find_package (MySQL) -macro_optional_find_package (ODBC) + +if (WITH_unixODBC) + macro_optional_find_package (ODBC REQUIRED) +else (WITH_unixODBC) + set(ODBC_FOUND FALSE) +endif (WITH_unixODBC) macro_optional_find_package (Postgres) macro_optional_find_package (LibDBI) macro_optional_find_package (Libintl) (In reply to coyote from comment #2) > Created attachment 465320 [details] > ebuild for the last version > > - added odbc USE > - patch for automagic fix will send to upstream Please update this thread when you hear back from upstream. Also, it'd be preferable if you can provide your change to the ebuild as a diff/patch. I'll look it over after upstream handles it. Looking at the existing code, where actually is the problem? There already is WITH_ODBC and it defaults to ON, so it works as expected. Actually all dependencies work this way, so it's consistent. So if you don't want ODBC, build with -DWITH_ODBC=OFF and it will work. https://github.com/gammu/gammu/issues/279#issuecomment-283328773 ebuild fo gammu-1.38.1 attached to fist post. IF you want to proxy maintain this, please take a look on https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers Thanks The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8d0bc939e335e51a0d595db992f081537fb9eb63 commit 8d0bc939e335e51a0d595db992f081537fb9eb63 Author: coyote <coyote@bks.tv> AuthorDate: 2017-09-04 15:22:22 +0000 Commit: Michael Palimaka <kensington@gentoo.org> CommitDate: 2017-10-16 11:13:41 +0000 app-mobilephone/gammu: bump version to 1.38.4 Switch to EAPI=6, exclude unneeded patches, fix automagic to ODBC. Closes: https://bugs.gentoo.org/608002 app-mobilephone/gammu/Manifest | 1 + .../gammu/files/gammu-1.38.4-smsd.patch | 22 ++++++++ app-mobilephone/gammu/gammu-1.38.4.ebuild | 63 ++++++++++++++++++++++ 3 files changed, 86 insertions(+) |