| Summary: | net-misc/networkmanager: Add elogind support | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Martijn Schmidt <martijn.schmidt> |
| Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bruce, floppym, martijn.schmidt, sven.eden |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 599470 | ||
| Attachments: |
Patch for networkmanager-1.4.4-r1 ebuild
Patch networkmanager to accept elogind Patch networkmanager-qt to allow networkmanager[elogind] Update init script to use elogind Updated patch to support elogind support networkmanager-1.8.0.ebuild.diff |
||
|
Description
Martijn Schmidt
2017-01-27 00:53:00 UTC
I am working on it. But I've seen, that kde-frameworks/networkmanager-qt has to be changed to allow elogind, too, as it depends on either >=net-misc/networkmanager-1.4.0-r1[consolekit,teamd=] or >=net-misc/networkmanager-1.4.0-r1[systemd,teamd=] It simply needs a line >=net-misc/networkmanager-1.4.0-r1[elogind,teamd=] as a third alternative. I have come up with the following changes to allow my Plasma system to use networkmanager with elogind. Please note, that I am *normally* using a dhcpcd-only system. I have therefore changed the ebuild so that USE="-dhclient" results in using dhcpcd. (Actually if you disable dhclient, the networkmanager configure script will use it anyway although it isn't there, unless told to use dhcpcd.) Created attachment 464500 [details, diff]
Patch for networkmanager-1.4.4-r1 ebuild
This patch adds USE="elogind" to have networkmanager to use elogind instead of systemd-login.
Further USE="-dhclient" will result in dhcpcd to be used.
Created attachment 464502 [details, diff]
Patch networkmanager to accept elogind
This patch adds --with-session-tracking=elogind support and patches
src/nm-sleep-monitor.c
and
src/nm-session-monitor.c
to make use of elogind.
Created attachment 464504 [details, diff]
Patch networkmanager-qt to allow networkmanager[elogind]
Plasma users need this, or networkmanager-qt insists on either systemd or consolekit.
Please send any relevant patches upstream. (In reply to Mike Gilbert from comment #6) > Please send any relevant patches upstream. Sure! Once they are tested. Currently NetworkManager works fine with dhcpcd using elogind-225.9999 on my laptop. If it still works fine (So no weird log messages) tonight at home, where it has to deal with wifi, I'll send it upstream tomorrow. Created attachment 464966 [details, diff]
Update init script to use elogind
I can't believe I forgot to upload that.
The init script already has a
use consolekit
clause, and when elogind is present, a
use elogind
clause should help.
Currently I have installed: - net-misc/networkmanager-1.4.4-r13::seden - net-misc/dhcpcd-6.11.5 - sys-auth/elogind-225.9999::seden With this setting all networking work just fine, configured from Plasma using networkmanager-qt. I have registered with bugzilla.gnome.org and will propose my patch upstream. Submitted as bug 779167 (https://bugzilla.gnome.org/show_bug.cgi?id=779167) Elogind support in NetworkManager has been merged: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=e40d47fe7ccd725ecf6231e0f1193a029ea05e47 Created attachment 465102 [details, diff] Updated patch to support elogind support This is an updated patch, that adds changes by Thomas Haller <thaller@redhat.com> made to the initial patch. This is essentially what has been merged into upstream. I have tested both builds - net-misc/networkmanager-1.4.4-r13 with Sven's original patches and net-misc/networkmanager-1.4.4-r14 with the patches that Thomas committed upstream. Works like a charm, and I have uninstalled ConsoleKit in its entirety. Typically use WiFi, but it also worked hotplugging my TB3-to-TB2 + Apple Thunderbolt 1GbE NIC on the Dell XPS 13 9360. So, fingers crossed for the next upstream release and hopefully we can then add the elogind USE flag to the in-tree ebuild! Created attachment 474512 [details, diff]
networkmanager-1.8.0.ebuild.diff
networkmanager-1.8.0 has upstream elogind support, let's make it available then.
Thanks, net-misc/netorkmanager-1.8.0 added USE=elogind in git commit 17287aa7d5aa639964c529c6ed08f9bcee2e172d Why do we have ?? ( consolekit elogind systemd ) (instead of ^^) when the suspend-resume stuff always falls back to at least consolekit in the usex chaining? Upstream has a final fallback to upower instead though (In reply to Mart Raudsepp from comment #16) upower was killed by Pacho in bc2837c7ea2af4ebec0629370da94686c2cdf1f7. There's no option to disable suspend/resume support entirely. The consolekit option requires no external build-time dependencies, so it makes a reasonable default when no other provider is selected. The dbus calls will just fail at runtime. In other words, it is entirely practical to use networkmanager without consolekit, elogind, and systemd. Please don't add an unnecessary REQUIRED_USE constraint. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a3d917e57fa37daea47fa0f1e3e4f5027510479d commit a3d917e57fa37daea47fa0f1e3e4f5027510479d Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2019-03-23 12:58:06 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2019-03-23 12:58:06 +0000 net-misc/networkmanager: explain consolkit default for suspend/resume Closes: https://bugs.gentoo.org/607352 Package-Manager: Portage-2.3.62_p4, Repoman-2.3.12_p87 Signed-off-by: Mike Gilbert <floppym@gentoo.org> net-misc/networkmanager/networkmanager-1.16.0.ebuild | 2 ++ 1 file changed, 2 insertions(+) |
