Summary: | dev-util/astyle-2.06 Changes all visibility to hidden - Code::Blocks no longer merges | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sven Eden <sven.eden> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED TEST-REQUEST | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Fix the visibility of astyle::ASFormatter and astyle::ASBeautifier |
Description
Sven Eden
2017-01-18 09:39:03 UTC
If I'm understanding the linked conversations correctly, this is an issue caused by code::blocks relying on an API that was meant to be hidden? And Fedora has changes to their astyle package that facilitate unbundling astyle from code::blocks (probably similar to us)? The proposed patch appears to be moving the #ifdefs and the accompanying functionality from astyle_main.h to astyle.h. Were there any important changes to the underlying code? A brief glance showed nothing different. Then the classes have 'EXPORT' added so that they are visible when #include'd, which codeblocks depends on (for now, it seems), correct? I've never used codeblocks before, so what should I be testing to ensure this patch works correctly? Thanks for reporting. (In reply to Daniel Campbell from comment #1) > I've never used codeblocks before, so what should I be testing to ensure > this patch works correctly? The minimal test program I have posted in my first comment. Although, at least with astyle-2.06, it is fixed. :-) Sorry for this, I am in a bad shape it seems. I was so happy that my astyle did not come from a local ebuild or something, that I totally forgot that I added my patch to /etc/portage/patches/dev-util/astyle-2.06 Upstream might change this in their next release. But for now the patch at least works for all consumers of /usr/include/astyle.h please retry with 3.0.1 |