Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 605676

Summary: media-tv/kodi-17.0_rc* : cmake project still use autoreconf during compile time
Product: Gentoo Linux Reporter: Marc Perrudin <gentoo>
Component: Current packagesAssignee: Gentoo Linux bug wranglers <bug-wranglers>
Status: RESOLVED FIXED    
Severity: enhancement CC: candrews
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: autotools.patch

Description Marc Perrudin 2017-01-14 11:40:00 UTC
Created attachment 460000 [details, diff]
autotools.patch

With the switch to cmake build system, the eautoreconf part was dropped. But some part of what kodi call externalproject still use autoreconf (cpluff, texturepacker...) during compile time.

I attach a patch for externalproject with included sources.
Comment 1 Craig Andrews gentoo-dev 2017-01-16 17:17:28 UTC
What problem does this proposed change solve?
Comment 2 Marc Perrudin 2017-01-16 18:12:56 UTC
I don't have a deep knowledge in portage but the direct use of autoreconf instead of eautoreconf seem to be discouraged (forbidden ?). 

This was done in the ebuild until rc, if it's ok to use autoreconf, fell free to close this bug.

Marc.
Comment 3 Craig Andrews gentoo-dev 2017-01-16 22:25:34 UTC
Thanks for that info, it makes to me.

I've included your patch in https://github.com/gentoo/gentoo/pull/3513

Thank you for this bug report and the patch fixing the issue!