Summary: | media-libs/flac-1.3.2 prints debug infos (caused by Gentoo-Patch) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Stefan Briesenick (RETIRED) <sbriesen> |
Component: | Current packages | Assignee: | Gentoo Sound Team <sound> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | gentoo-bugs, martin |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 540072 |
Description
Stefan Briesenick (RETIRED)
2017-01-05 03:44:07 UTC
Looks like this is the relevant code: http://git.xiph.org/?p=flac.git;a=blob;f=src/libFLAC/cpu.c;h=9a3feaa545e8e900ec4722b4756768b53d427103;hb=601c051df40d186bf1b22f0262721157599b92be#l401 That print is hidden behind #ifdef DEBUG, but I don't have debug USE enabled for this package so it must be defined somewhere else. if nothing helps, patch it out for the time being. But it should reported upstream I guess. #ifdef DEBUG #include <stdio.h> #define dfprintf fprintf #else /* This is bad practice, it should be a static void empty function */ #define dfprintf(file, format, ...) #endif easy fix would be to replace the "#ifdef DEBUG" to "#ifdef FLAC_DEBUG" or something like that. But I try to find the place where DEBUG is set. Maybe buried inside autotools stuff... ok, it's not an upstream bug! compiled it manually after ebuild ... unpack. No Debug output! So maybe that $(use_enable debug) causes some harm. I try to figure it out. ok, it have to be buried inside the gentoo patches! if I only unpack the source with "ebuild .. unpack", there's no debug output. But if I use also "ebuild .. prepare", we have the debug output. flac-1.3.2-cflags.patch there's an unconditional -DDEBUG. WHY?! It's not there in flac-1.3.1-cflags.patch. after manually uncomment this: CPPFLAGS="-DDEBUG $CPPFLAGS" inside the patched configure, there's no more debug output. So I guess, we (well, 'me') found it. Please fix! Thanks! /uncomment/comment out/ ;-) ping. current version is broken by gentoo patch. No one feels responsible to fix it? I've fixed it and submitted all the patches upstream. With USE="-debug": flac 1.3.2 Copyright (C) 2000-2009 Josh Coalson, 2011-2016 Xiph.Org Foundation flac comes with ABSOLUTELY NO WARRANTY. This is free software, and you are welcome to redistribute it under certain conditions. Type `flac' for details. a2002011001-e02.wav: wrote 5440305 bytes, ratio=0,568 With USE="debug": flac 1.3.2 Copyright (C) 2000-2009 Josh Coalson, 2011-2016 Xiph.Org Foundation flac comes with ABSOLUTELY NO WARRANTY. This is free software, and you are welcome to redistribute it under certain conditions. Type `flac' for details. CPU info (x86-64): SSE3 ....... Y SSSE3 ...... Y SSE41 ...... Y SSE42 ...... Y AVX ........ Y FMA ........ n AVX2 ....... n AVX OS sup . Y a2002011001-e02.wav: wrote 5440305 bytes, ratio=0,568 This seems correct to me. Reopen if issues persist. commit 29397cdf2756c3fc6db869cd0e7e3db59536e9c5 Author: David Seifert <soap@gentoo.org> Date: Fri Jan 13 19:35:16 2017 +0100 media-libs/flac: Make debugging info dependent on USE="debug" Gentoo-bug: 604718 |