Bug 604666

Summary:	fix compiler warnings
Product:	Gentoo Hosted Projects	Reporter:	Benda Xu <heroxbd>
Component:	OpenRC	Assignee:	OpenRC Team <openrc>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847281
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=619370
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	0061-fix-compiler-warnings.patch 0062-fix-compiler-warnings.patch 0063-fix-compiler-warnings.patch

Description Benda Xu gentoo-dev

2017-01-04 16:32:48 UTC

0061-fix-compiler-warnings.patch fixes CPPFLAGS and removes unused variables.
0062-fix-compiler-warnings.patch fixes indentation issues making the compiler
issue a warning. Please review these changes to make sure I've made the right
corrections.
Finally 0063-fix-compiler-warnings.patch fixes warnings about unused variables
on glibc-based systems using the already defined macro _unused in helpers.h.

Reproducible: Always

Comment 1 Benda Xu gentoo-dev

2017-01-04 16:34:01 UTC

Created attachment 458752 [details, diff]
0061-fix-compiler-warnings.patch

fixes CPPFLAGS and removes unused variables.

Comment 2 Benda Xu gentoo-dev

2017-01-04 16:34:38 UTC

Created attachment 458754 [details, diff]
0062-fix-compiler-warnings.patch

fixes indentation issues making the compiler issue a warning.

Comment 3 Benda Xu gentoo-dev

2017-01-04 16:35:17 UTC

Created attachment 458756 [details, diff]
0063-fix-compiler-warnings.patch

fixes warnings about unused variables on glibc-based systems using the already defined macro _unused in helpers.h.

Comment 4 William Hubbs gentoo-dev

2017-01-04 23:29:16 UTC

The following commits that take care of this have been added to git:

https://github.com/openrc/openrc/commit/7056b56
https://github.com/openrc/openrc/commit/074d90f
https://github.com/openrc/openrc/commit/92325b4
https://github.com/openrc/openrc/commit/c304522

These will be part of OpenRC-0.24, and possibly 0.23.1.

I could not remove the unused variables you mentioned because they are
now being used.

Thanks much.

William

Comment 5 Benda Xu gentoo-dev

2017-01-18 06:24:38 UTC

Great!  Thanks Bill.