Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 603762

Summary: >=app-emulation/virtualbox-modules-5.1.12 needs a patch for kernel 4.10
Product: Gentoo Linux Reporter: Helmut Jarausch <jarausch>
Component: Current packagesAssignee: Lars Wendler (Polynomial-C) (RETIRED) <polynomial-c>
Status: RESOLVED FIXED    
Severity: normal CC: francoisvalenduc, masterzorag, tb
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: patch for kernel 4.10
patch for kernel 4.10.0-rc2

Description Helmut Jarausch 2016-12-26 13:44:35 UTC
Created attachment 457422 [details, diff]
patch for kernel 4.10

Kernel 4.10 has 
struct taint_flag {
	char true;	/* character printed when tainted */
	char false;	/* character printed when not tainted */
	bool module;	/* also show as a per-module taint flag */
};

which won't compile if any macro defining 'true' or 'false' is in effect.

Furthermore, get_user_pages_remote has got an additional parameter int *locked.

My patch doesn't initialize this parameter which might be wrong
Comment 1 Helmut Jarausch 2017-01-02 11:19:01 UTC
Created attachment 458318 [details, diff]
patch for kernel 4.10.0-rc2
Comment 2 Helmut Jarausch 2017-01-02 11:20:36 UTC
While 4.10.0-rc1 still contained the dummy declaration

static inline int register_cpu_notifier(struct notifier_block *nb)
{
	return 0;
}

this was removed in 4.10.0-rc2 .
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2017-03-13 12:50:56 UTC
*** Bug 606252 has been marked as a duplicate of this bug. ***
Comment 4 Helmut Jarausch 2017-03-13 15:30:22 UTC
I can confirm that virtualbox-modules-5.1.16 build just fine with
kernel 4.11.0-rc2 without any patching of the kernel.