Bug 603630

Summary:	net-fs/samba: make python optional
Product:	Gentoo Linux	Reporter:	SpanKY <vapier>
Component:	Current packages	Assignee:	Gentoo's SAMBA Team <samba>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	axs
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	603602
Bug Blocks:
Attachments:	samba-4.6.3.patch

Description SpanKY gentoo-dev

2016-12-24 09:06:02 UTC

once bug 603602 is resolved, it seems like we can make python optional in the samba build itself ?  is there something obvious i'm missing ?

@@ -26,7 +26,7 @@
 SLOT="0"
 
 IUSE="acl addc addns ads avahi client cluster cups dmapi fam gnutls iprint
-ldap pam quota selinux syslog +system-mitkrb5 systemd test winbind"
+ldap pam python quota selinux syslog +system-mitkrb5 systemd test winbind"
 
 MULTILIB_WRAPPED_HEADERS=(
    /usr/include/samba-4.0/policy.h
@@ -40,7 +40,7 @@
 )
 
 # sys-apps/attr is an automagic dependency (see bug #489748)
-CDEPEND="${PYTHON_DEPS}
+CDEPEND="python? ( ${PYTHON_DEPS} )
    >=app-arch/libarchive-3.1.2[${MULTILIB_USEDEP}]
    dev-lang/perl:=
    dev-libs/libaio[${MULTILIB_USEDEP}]
@@ -49,13 +49,13 @@
    dev-libs/popt[${MULTILIB_USEDEP}]
    sys-libs/readline:=
    virtual/libiconv
-   dev-python/subunit[${PYTHON_USEDEP},${MULTILIB_USEDEP}]
+   python? ( dev-python/subunit[${PYTHON_USEDEP},${MULTILIB_USEDEP}] )
    sys-apps/attr[${MULTILIB_USEDEP}]
    sys-libs/libcap
-   >=sys-libs/ldb-1.1.26[ldap(+)?,${MULTILIB_USEDEP}]
+   >=sys-libs/ldb-1.1.26[ldap(+)?,python(+)?,${MULTILIB_USEDEP}]
    sys-libs/ncurses:0=[${MULTILIB_USEDEP}]
-   >=sys-libs/talloc-2.1.6[python,${PYTHON_USEDEP},${MULTILIB_USEDEP}]
-   >=sys-libs/tdb-1.3.8[python,${PYTHON_USEDEP},${MULTILIB_USEDEP}]
+   >=sys-libs/talloc-2.1.6[python?,${PYTHON_USEDEP},${MULTILIB_USEDEP}]
+   >=sys-libs/tdb-1.3.8[python?,${PYTHON_USEDEP},${MULTILIB_USEDEP}]
    >=sys-libs/tevent-0.9.28[${MULTILIB_USEDEP}]
    sys-libs/zlib[${MULTILIB_USEDEP}]
    pam? ( virtual/pam )
@@ -81,7 +81,7 @@
 
 REQUIRED_USE="addc? ( gnutls !system-mitkrb5 )
    ads? ( acl gnutls ldap )
-   ${PYTHON_REQUIRED_USE}"
+   python? ( ${PYTHON_REQUIRED_USE} )"
 
 S="${WORKDIR}/${MY_P}"
 
@@ -144,6 +144,7 @@
            $(use_with ldap)
            $(use_with pam)
            $(usex pam "--with-pammodulesdir=${EPREFIX}/$(get_libdir)/security" '')
+           $(use_enable python)
            $(use_with quota quotas)
            $(use_with syslog)
            $(use_with systemd)

Comment 1 SpanKY gentoo-dev

2017-02-15 18:43:49 UTC

looks like Ian added this with samba-4.6.0_rc3

Comment 2 jack_mort 2017-05-24 07:54:39 UTC

Created attachment 474008 [details, diff]
samba-4.6.3.patch

Comment 3 jack_mort 2017-05-24 07:55:46 UTC

Hi,

Current ebuild is still pulling python dependencies as it is missing some optional checks with python.

Attached is a patch proposal.

Regards.