Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 603602

Summary: sys-libs/ldb: make python optional
Product: Gentoo Linux Reporter: SpanKY <vapier>
Component: Current packagesAssignee: Gentoo's SAMBA Team <samba>
Status: RESOLVED FIXED    
Severity: normal CC: axs
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 603630    

Description SpanKY gentoo-dev 2016-12-23 17:55:09 UTC
it's possible to build ldb w/out python support.  can we add a USE flag ?

or may i commit the following to recent versions ?

@@ -15,7 +15,7 @@
 LICENSE="LGPL-3"
 SLOT="0/${PV}"
 KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86 ~amd64-fbsd ~x86-fbsd"
-IUSE="doc +ldap"
+IUSE="doc +ldap python"
 
 RDEPEND="!elibc_FreeBSD? ( dev-libs/libbsd[${MULTILIB_USEDEP}] )
    dev-libs/popt[${MULTILIB_USEDEP}]
@@ -24,7 +24,7 @@
    >=sys-libs/tdb-1.3.10[python,${MULTILIB_USEDEP}]
    !!<net-fs/samba-3.6.0[ldb]
    !!>=net-fs/samba-4.0.0[ldb]
-   ${PYTHON_DEPS}
+   python? ( ${PYTHON_DEPS} )
    ldap? ( net-nds/openldap )
    "
 
@@ -33,7 +33,7 @@
    virtual/pkgconfig
    ${RDEPEND}"
 
-REQUIRED_USE="${PYTHON_REQUIRED_USE}"
+REQUIRED_USE="python? ( ${PYTHON_REQUIRED_USE} )"
 
 WAF_BINARY="${S}/buildtools/bin/waf"
 
@@ -55,14 +55,12 @@
 multilib_src_configure() {
    local myconf=(
        $(usex ldap '' --disable-ldap) \
+       $(multilib_native_usex python '' --disable-python) \
        --disable-rpath \
        --disable-rpath-install --bundled-libraries=NONE \
        --with-modulesdir="${EPREFIX}"/usr/$(get_libdir)/samba \
        --builtin-libraries=NONE
    )
-   if ! multilib_is_native_abi; then
-       myconf+=( --disable-python )
-   fi
    waf-utils_src_configure "${myconf[@]}"
 }
Comment 1 SpanKY gentoo-dev 2017-02-15 18:43:28 UTC
looks like Ian added this with samba-4.6.0_rc3
Comment 2 SpanKY gentoo-dev 2017-02-15 18:44:38 UTC
wrong bug, but Ian still fixed this in ldb-1.1.29-r1

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=94612023ec479de3b509eb6c67309481f3638582
Comment 3 Ian Stakenvicius (RETIRED) gentoo-dev 2017-02-15 20:30:53 UTC
Yep, wrong bug.  And thanks for closing, I didn't hit 'save changes' on the post i had prepared here either it seems.