Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 603000

Summary: x11-misc/spacefm-1.0.4 : vfs/vfs-volume-nohal.c:1096:29: error: called object ‘major’ is not a function or function pointer
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: zlg (RETIRED) <zlg>
Status: RESOLVED FIXED    
Severity: normal Keywords: InVCS
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 575232    
Attachments: config.log
emerge-history.txt
environment
etc.portage.tbz2
x11-misc:spacefm-1.0.4:20161218-123644.log
include sys/sysmacros.h
patch for spacefm-1.0.4-r1.ebuild

Description Toralf Förster gentoo-dev 2016-12-18 12:53:02 UTC
vfs/vfs-volume-nohal.c: In function ‘info_mount_points’:
vfs/vfs-volume-nohal.c:1096:29: error: called object ‘major’ is not a function or function pointer
                     major = major( statbuf.st_rdev );
                             ^
vfs/vfs-volume-nohal.c:1047:13: note: declared here


$ cat emerge-info.txt
  -----------------------------------------------------------------

  This is an stable amd64 chroot image (named amd64-plasma-stable_20161215-094052) at a hardened host acting as a tinderbox.

  -----------------------------------------------------------------
  USE flags in make.conf:
USE="  pax_kernel xtpax -cdinstall -oci8 -bindist ssp egl gpg kvm mdnsresponder-compat modplug mp4 networking openexr plasma png pypy sql sqlite system-libs webstart ffmpeg icu svc gd truetype exif mod python boost messages video"
  -----------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-4.9.3
 [2] x86_64-pc-linux-gnu-4.9.4 *
llvm-config --version:
3.7.1
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm
Available Python interpreters:
  [1]   python2.7
  [2]   python3.4 *
Available Ruby profiles:
  [1]   ruby21 (with Rubygems) *
java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 3.2.0 [icedtea-bin-8]
  -----------------------------------------------------------------

Portage 2.3.0 (python 3.4.5-final-0, default/linux/amd64/13.0/desktop/plasma, gcc-4.9.4, glibc-2.24, 4.8.15-hardened x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.8.15-hardened-x86_64-Intel-R-_Core-TM-_i7-3930K_CPU_@_3.20GHz-with-gentoo-2.3
KiB Mem:    65285560 total,   2385252 free
KiB Swap:   67108860 total,  67108860 free
Timestamp of repository gentoo: Sun, 18 Dec 2016 11:22:16 +0000
sh bash 4.3_p48-r1
ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1
app-shells/bash:          4.3_p48-r1::gentoo
dev-java/java-config:     2.2.0-r3::gentoo
dev-lang/perl:            5.22.3_rc4::gentoo
dev-lang/python:          2.7.12::gentoo, 3.4.5::gentoo
dev-util/cmake:           3.6.3::gentoo
dev-util/pkgconfig:       0.28-r2::gentoo
sys-apps/baselayout:      2.3::gentoo
sys-apps/openrc:          0.22.4::gentoo
sys-apps/sandbox:         2.10-r1::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69::gentoo
sys-devel/automake:       1.11.6-r1::gentoo, 1.14.1::gentoo, 1.15::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo
sys-devel/gcc:            4.9.3::gentoo, 4.9.4::gentoo
sys-devel/gcc-config:     1.7.3::gentoo
sys-devel/libtool:        2.4.6-r2::gentoo
sys-devel/make:           4.1-r1::gentoo
sys-kernel/linux-headers: 4.3::gentoo (virtual/os-headers)
sys-libs/glibc:           2.24::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: 1

tinderbox
    location: /tmp/tb/data/portage
    masters: gentoo
    priority: 2

local
    location: /usr/local/portage
    masters: gentoo
    priority: 99

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-Wimplicit-function-declaration -march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-Wimplicit-function-declaration -march=native -O2 -pipe"
DISTDIR="/var/tmp/distfiles"
EMERGE_DEFAULT_OPTS="--verbose --verbose-conflicts --color=n --nospinner --tree --quiet-build"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox parallel-fetch preserve-libs protect-owned sandbox sfperms strict test-fail-continue unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.uni-erlangen.de/pub/mirrors/gentoo rsync://mirror.netcologne.de/gentoo/ ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gor.bytemark.co.uk/gentoo/ rsync://ftp.snt.utwente.nl/gentoo"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j1"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 berkdb bluetooth boost branding bzip2 cairo cdda cdr cli consolekit cracklib crypt cups cxx dbus declarative dri dts dvd dvdr egl emboss encode exif fam ffmpeg firefox flac fortran gd gdbm gif glamor gpg gpm gtk iconv icu ipv6 jpeg kde kipi kvm lcms ldap libnotify mad mdnsresponder-compat messages mmx mmxext mng mod modplug modules mp3 mp4 mpeg multilib ncurses networking nls nptl ogg openexr opengl openmp pam pango pax_kernel pcre pdf phonon plasma png policykit ppds pypy python qml qt3support qt4 qt5 readline sdl seccomp semantic-desktop session spell sql sqlite sse sse2 ssl ssp startup-notification svc svg system-libs tcpd tiff truetype udev udisks unicode upower usb video vorbis webstart widgets wxwidgets x264 xattr xcb xcomposite xinerama xml xscreensaver xtpax xv xvid zlib" ABI_X86="64" ALSA_CARDS="hda-intel" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" L10N="be bg dsb es es-ES zh-TW" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby21" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Toralf Förster gentoo-dev 2016-12-18 12:53:08 UTC
Created attachment 456566 [details]
config.log
Comment 2 Toralf Förster gentoo-dev 2016-12-18 12:53:11 UTC
Created attachment 456568 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2016-12-18 12:53:14 UTC
Created attachment 456570 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2016-12-18 12:53:17 UTC
Created attachment 456572 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2016-12-18 12:53:20 UTC
Created attachment 456574 [details]
x11-misc:spacefm-1.0.4:20161218-123644.log
Comment 6 zlg (RETIRED) gentoo-dev 2016-12-18 16:32:12 UTC
This is the second package having this issue. I'll prepare patches for this and bug 580364 by the end of the day. I've informed upstream of the issue and will be in contact with them in the mean time.
Comment 7 zlg (RETIRED) gentoo-dev 2016-12-19 10:17:33 UTC
Created attachment 456706 [details, diff]
include sys/sysmacros.h

I've successfully applied this patch and it appears to work fine on my system, but since I didn't run into this issue I can't really test it. If you can confirm this fixes it, I'll commit asap.
Comment 8 zlg (RETIRED) gentoo-dev 2016-12-19 10:26:37 UTC
Created attachment 456708 [details, diff]
patch for spacefm-1.0.4-r1.ebuild

Updated ebuild to apply said patch; also upgraded to EAPI 6.

Combined with attachment 456706 [details, diff], I can confirm it compiles and runs on my system.
Comment 9 zlg (RETIRED) gentoo-dev 2016-12-30 03:38:05 UTC
Upstream has added an Issue regarding this: https://github.com/IgnorantGuru/spacefm/issues/678

The good news is anything from current Git has this covered, so we'll just need the patch for 1.0.4 and 1.0.5 which I'm working to get revbumped to fix this.
Comment 10 zlg (RETIRED) gentoo-dev 2017-01-02 12:37:58 UTC
Pushed to gentoo.git.

Commit-ID: e51eaf345132b3494c05db6315e8531a359ca68b
Comment 11 zlg (RETIRED) gentoo-dev 2017-05-11 23:25:04 UTC
Looks like the first patch wasn't covering everything for glibc 2.25. It has since been corrected.

commit de2db60f8afd411eb0340c6bf6ed833407e8d7a3
Author: Daniel Campbell <zlg@gentoo.org>
Date:   Thu May 11 16:23:21 2017 -0700

    x11-misc/spacefm: Improve patch coverage wrt bug 603000
    
    Thanks to Polynomial-C for catching this.
    
    Gentoo-Bug: 603000
    Gentoo-Bug-URL: https://bugs.gentoo.org/603000
    Package-Manager: Portage-2.3.5, Repoman-2.3.2
Comment 12 zlg (RETIRED) gentoo-dev 2017-07-27 06:26:48 UTC
It's been a few months and no further issues reported. Closing.