Bug 60295 – xorg-x11-6.7.99.2 radeon driver fails to build on big-endian systems

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description SpanKY 2004-08-14 00:22:24 UTC]

on my ppc, i get this failure:

gcc -O2 -pipe -mcpu=7450 -fno-strict-aliasing -fsigned-char    -fno-merge-constants -I. -I../../../../../../programs/Xserver/hw/xfree86/common -I../../../../../../programs/X
server/hw/xfree86/os-support -I../../../../../../programs/Xserver/hw/xfree86            -I../../../../../../programs/Xserver/hw/xfree86/vbe -I../../../../../../programs/Xser
ver/hw/xfree86/int10            -I../../../../../../programs/Xserver/hw/xfree86/ddc -I../../../../../../programs/Xserver/hw/xfree86/i2c            -I../../../../../../progra
ms/Xserver/hw/xfree86/rac -I../../../../../../programs/Xserver/hw/xfree86/ramdac            -I../../../../../../programs/Xserver/hw/xfree86/shadowfb -I../../../../../../prog
rams/Xserver/hw/xfree86/xaa            -I../../../../../../programs/Xserver/hw/xfree86/xf4bpp -I../../../../../../programs/Xserver/hw/xfree86/xf1bpp            -I../../../..
/../../programs/Xserver/hw/xfree86/vgahw -I../../../../../../programs/Xserver/hw/xfree86/fbdevhw            -I../../../../../../programs/Xserver/mfb -I../../../../../../programs/Xserver/fb -I../../../../../../programs/Xserver/mi            -I../../../../../../programs/Xserver/miext/shadow            -I../../../../../../programs/Xserver/render -I../../../../../../programs/Xserver/Xext -I../../../../../../programs/Xserver/include            -I../../../../../../programs/Xserver/GL/dri -I../../../../../../lib/GL/dri -I../../../../../../include               -I../../../../../../extras/drm/shared -I../../../../../../include/fonts -I../../../../../../include/extensions -I../../../../../../exports/include/X11  -I../../../../../.. -I../../../../../../exports/include   -Dlinux -D__powerpc__ -D_POSIX_C_SOURCE=199309L                              -D_POSIX_SOURCE -D_XOPEN_SOURCE                -D_BSD_SOURCE -D_SVID_SOURCE                              -D_GNU_SOURCE          -DSHAPE -DXINPUT -DXKB -DLBX -DXAPPGROUP        -DXCSECURITY -DTOGCUP   -DXF86BIGFONT -DDPMSExtension    -DPIXPRIV -DPANORAMIX   -DRENDER -DRANDR       -DXFIXES -DDAMAGE -DCOMPOSITE -DXEVIE -DGCCUSESGAS -DAVOID_GLYPHBLT -DPIXPRIV -DSINGLEDEPTH                             -DXFreeXDGA -DXvExtension                      -DXFree86LOADER  -DXFree86Server                                 -DXF86VIDMODE  -DXvMCExtension                          -DSMART_SCHEDULE                       -DBUILDDEBUG -DXResExtension                             -DX_BYTE_ORDER=X_BIG_ENDIAN                             -DXORG_VERSION_CURRENT="(((6) * 10000000) + ((7) * 100000) + ((99) * 1000) + 2)" -DNDEBUG   -DFUNCPROTO=15 -DNARROWPROTO  -DIN_MODULE -DXFree86Module -DAVOID_CPIO  -DAVOID_NON_PCI -DGLXEXT -DXF86DRI -DGLX_DIRECT_RENDERING -DGLX_USE_DLOPEN -DGLX_USE_MESA    -c radeon_accel.c
In file included from radeon_accel.c:426:
radeon_render.c: In function `R100SetupTextureCP':
radeon_render.c:389: error: redeclaration of `RADEONMMIO'
radeon_render.c:387: error: `RADEONMMIO' previously declared here
radeon_render.c: In function `R200SetupTextureCP':
radeon_render.c:701: error: redeclaration of `RADEONMMIO'
radeon_render.c:699: error: `RADEONMMIO' previously declared here
make[7]: *** [radeon_accel.o] Error 1
make[7]: Leaving directory `/var/tmp/portage/xorg-x11-6.7.99.2/work/xc/programs/Xserver/hw/xfree86/drivers/ati'
make[6]: *** [all] Error 2
make[6]: Leaving directory `/var/tmp/portage/xorg-x11-6.7.99.2/work/xc/programs/Xserver/hw/xfree86/drivers'
make[5]: *** [all] Error 2
make[5]: Leaving directory `/var/tmp/portage/xorg-x11-6.7.99.2/work/xc/programs/Xserver/hw/xfree86'
make[4]: *** [hw/xfree86] Error 2
make[4]: Leaving directory `/var/tmp/portage/xorg-x11-6.7.99.2/work/xc/programs/Xserver'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/var/tmp/portage/xorg-x11-6.7.99.2/work/xc/programs'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/var/tmp/portage/xorg-x11-6.7.99.2/work/xc'
make[1]: *** [World] Error 2
make[1]: Leaving directory `/var/tmp/portage/xorg-x11-6.7.99.2/work/xc'
make: *** [World] Error 2

!!! ERROR: x11-base/xorg-x11-6.7.99.2 failed.
!!! Function src_compile, Line 608, Exitcode 2
!!! (no error message)
!!! If you need support, post the topmost build error, NOT this status message.

Portage 2.0.51_pre17 (default-ppc-2004.1, gcc-3.3.3, glibc-2.3.3.20040420-r1, 2.6.7-rc3 ppc 7455, altivec supported)
=================================================================
System uname: 2.6.7-rc3 ppc 7455, altivec supported
Gentoo Base System version 1.5.2
distcc 2.16 powerpc-unknown-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.3 [enabled]
Autoconf: sys-devel/autoconf-2.59-r4
Automake: sys-devel/automake-1.8.5-r1
Binutils: sys-devel/binutils-2.15.90.0.3-r3
Headers:  sys-kernel/linux-headers-2.4.22
Libtools: sys-devel/libtool-1.5.2-r5
ACCEPT_KEYWORDS="ppc ~ppc"
AUTOCLEAN="yes"
CFLAGS="-O2 -pipe -mcpu=7450 -maltivec -mabi=altivec -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE"
CHOST="powerpc-unknown-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.2/share/config /usr/kde/3/share/config /usr/share/config /var/qmail/alias /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -pipe -mcpu=7450 -maltivec -mabi=altivec -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE"
DISTDIR="/usr/portage/distfiles"
FEATURES="ccache noauto noinfo sandbox"
GENTOO_MIRRORS=" http://gentoo.oregonstate.edu http://www.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://gentoo/gentoo-portage"
USE="X alsa altivec apache2 apm cdr crypt cups curl dedicated dga directfb dvd encode esd etheral fam fbcon flac flash foomaticdb gd gd-external gdbm gif gnome-libs gps gtk gtk2 imagemagick imap imlib ipv6 joystick jpeg mad maildir mikmod mitshm mpeg mysql ncurses nls oggvorbis opengl pam pcmcia perl png pnp ppc python readline samba sdl snmp socks5 spell ssl tcltk tcpd tiff truetype unicode usb xml xml2 xmms xosd xv zlib video_cards_radeon"

[Comment 1 David Holm (RETIRED) 2004-08-14 05:42:44 UTC]

Remove the following lines from /var/tmp/portage/xorg-x11-6.7.99.2/work/xc/programs/Xserver/hw/xfree86/drivers/ati/radeon_render.c (line 387 and 699) and it should compile:
#if X_BYTE_ORDER == X_BIG_ENDIAN && defined(ACCEL_CP)
    unsigned char *RADEONMMIO = info->MMIO;
#endif

[Comment 2 Ferris McCormick (RETIRED) 2004-08-19 13:03:25 UTC]

Also on sparc. Adding sparc to CC list & adding a little patch incorporating the effect
of Comment #1.  See bug 60305 for how I use it.

[Comment 3 Ferris McCormick (RETIRED) 2004-08-19 13:08:55 UTC]

Created attachment 37757 [details, diff]
Patch for Bigendian Radeon compile problem (promised in Comment 2)

Little patch promised in Comment 2.  Gets rid of the double declaration of
RADEONMMIO
when you are--
#if X_BYTE_ORDER == X_BIG_ENDIAN && defined(ACCEL_CP)

[Comment 4 Adam Jackson 2004-08-21 22:50:33 UTC]

reported upstream as http://freedesktop.org/bugzilla/show_bug.cgi?id=1156

[Comment 5 Adam Jackson 2004-08-22 10:42:52 UTC]

proposed patch at https://freedesktop.org/bugzilla/attachment.cgi?id=702&action=view

could you test please?

[Comment 6 Donnie Berkholz (RETIRED) 2004-08-26 21:43:01 UTC]

Committed upstream.

[Comment 7 Ferris McCormick (RETIRED) 2004-08-30 12:49:31 UTC]

Radeon drivers all build on sparc64 with 6.7.99.903 out of the box.  So, no longer a problem on sparc.

[Comment 8 Hardave Riar (RETIRED) 2004-09-01 22:12:49 UTC]

6.7.99.903 compiles without error on mips.

[Comment 9 Luca Barbato 2004-09-06 08:02:58 UTC]

looks like mergefb isn't working as supposed and X -configure lead to a nice sig11 w/out apparent reason.

[Comment 10 Joshua Baergen (RETIRED) 2005-11-20 11:19:27 UTC]

The build problem is fixed.

[Comment 11 Joshua Baergen (RETIRED) 2005-11-20 11:19:54 UTC]

Fixed for all current versions.