Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 602650

Summary: net-analyzer/smokeping: ebuild improvements
Product: Gentoo Linux Reporter: Michael Orlitzky <mjo>
Component: Current packagesAssignee: Netmon Herd <netmon>
Status: CONFIRMED ---    
Severity: normal CC: henson, jstein
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Michael Orlitzky gentoo-dev 2016-12-14 15:05:29 UTC
The ebuilds for smokeping do one thing that is *really* suspicious:

  if use apache2 ; then
      fowners apache:apache /var/lib/${PN}/.simg
      fowners -R apache:apache /var/www
  else
      ...

Smokeping installs to /var/www/localhost, but /var/www doesn't belong to it. That's a common location where web hosts keep their site directories, e.g.

  /var/www/example.com/www
  /var/www/example.net/git

Changing ownership of that whole tree to apache:apache can be disastrous.

Some other minor issues: the calls to "rm" and "mv" need "|| die", and the pkg_postinst() stuff looks like it's already performed in src_install().
Comment 1 nic 2021-09-19 20:38:39 UTC
Hello- These adjustments seem more sensible, although I am not running apache myself to validate further. Could there be collisions with localhost/cgi-bin too?

    if use apache2 ; then
        fowners apache:apache /var/lib/${PN}/.simg
        fowners -R apache:apache /var/www/localhost/${PN}
        fowners -R apache:apache /var/www/localhost/cgi-bin
    else
Comment 2 Jonas Stein gentoo-dev 2021-12-01 21:52:53 UTC
|| die was added