Bug 602276

Summary:	x11-wm/fvwm-2.6.5-r1[-nls]: incorrect window title encoding
Product:	Gentoo Linux	Reporter:	Ryoto Yayame <kanito.tasoga>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	proxy-maint
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	599144
Bug Blocks:
Attachments:	fvwm-2.6.5-r1.ebuild patch to add iconv USE flag

Description Ryoto Yayame 2016-12-10 18:45:12 UTC

Created attachment 455776 [details, diff]
fvwm-2.6.5-r1.ebuild patch to add iconv USE flag

If using x11-wm/fvwm[-nls], the current FVWM ebuild not only uses "--disable-nls", but also "--disable-iconv", which for some reason prevents the proper encoding of window titles on my system (which should otherwise fully support Unicode, and which uses the "en_US.UTF-8" locale).

This can be tested in Firefox with the following Wikipedia article, for example:
https://ja.wikipedia.org/wiki/日本
(proper tab title, but incorrect window title, looking like UTF-8 displayed as latin1 or something like that...)

If I emerge x11-wm/fvwm with the "nls" USE flag, and just restart FVWM with its `Restart` command, window titles are immediately working as they should.


The "nls" USE flag should only be used for interface translations, not for general Unicode support.


The "iconv" USE flag should probably be used instead, although this behavior of FVWM isn't intuitive...


I'm attaching an ebuild patch, with an ewarn when emerging FVWM with USE="-iconv", to clarify this side effect. I also added virtual/libintl and virtual/libiconv dependencies depending on these "nls" and "iconv" USE flags (they are necessary if not using glibc, right? they are both mentioned in the configure files).

I didn't add a REQUIRED_USE="nls? ( iconv )", because FVWM can apparently be configured with USE="nls -iconv" without issue:

With Gettext Native Lang support? yes (libc)
With Iconv support? no: Explicitly disabled

Comment 1 Pacho Ramos gentoo-dev

2018-10-14 12:29:10 UTC

I wouldn't make iconv optional as utf8 support must be there always

Comment 2 Larry the Git Cow gentoo-dev

2018-10-14 13:02:45 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1a84ca03bce720ce9d1d83e4ced78c3f32d84ce7

commit 1a84ca03bce720ce9d1d83e4ced78c3f32d84ce7
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2018-10-14 12:33:30 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2018-10-14 13:02:25 +0000

    x11-wm/fvwm: Ensure utf8 works always (#602276), use eapi7
    
    Closes: https://bugs.gentoo.org/602276
    Closes: https://bugs.gentoo.org/592322
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 x11-wm/fvwm/fvwm-2.6.8-r1.ebuild | 155 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 155 insertions(+)