Bug 602024

Summary:	app-laptop/nvidiabl fails to build with Linux kernel version 4.8
Product:	Gentoo Linux	Reporter:	Eric Hermes <erichermes>
Component:	Current packages	Assignee:	Jelte Fennema <gentoobugzilla>
Status:	RESOLVED WONTFIX
Severity:	normal	CC:	mike, proxy-maint, treecleaner
Priority:	Normal	Keywords:	PMASKED
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Deadline:	2020-01-04
Attachments:	emerge --info gzipped build.log patch to replace deprecated DEFINE_PCI_DEVICE_TABLE macro Modified Ebuild

Description Eric Hermes 2016-12-08 19:13:51 UTC

app-laptop/nvidiabl fails to build on more recent Linux kernels due to deprecation of the DEFINE_PCI_DEVICE_TABLE macro. The first error message that is printed is:

/var/tmp/portage/app-laptop/nvidiabl-0.87/work/nvidiabl-0.87/nvidiabl-models.h:24:8: error: type defaults to ‘int’ in declaration of ‘DEFINE_PCI_DEVICE_TABLE’ [-Werror=implicit-int]

(I apologize if this is somewhat mangled, I copied it from the build.log directly, and I still don't know how to deal with those annoying color control characters, so I removed them manually)

Apparently Manjaro has some patches to let nvidiabl build on Linux 4.8, but I have not tried them: https://github.com/manjaro/packages-extra/tree/master/linux48-extramodules/nvidiabl

Comment 1 Eric Hermes 2016-12-08 19:14:10 UTC

Created attachment 455540 [details]
emerge --info

Comment 2 Eric Hermes 2016-12-08 19:15:11 UTC

Created attachment 455542 [details]
gzipped build.log

Apparently the build log failed to attach because it is 1.2MB. I've gzipped and attached it.

Comment 3 Mike Benson 2017-03-24 00:30:57 UTC

Created attachment 468114 [details, diff]
patch to replace deprecated DEFINE_PCI_DEVICE_TABLE macro

I have the same problem with compiling nvidiabl on a 4.9.x kernel. The attached patch replaces the deprecated DEFINE_PCI_DEVICE_TABLE macro with explicit structure declarations, which permits the code to compile

Comment 4 Mike Benson 2017-03-24 00:37:51 UTC

Created attachment 468116 [details]
Modified Ebuild

I have the same problem with compiling nvidiabl on a 4.9.x kernel. The attached ebuild inserts a patch that replaces the deprecated DEFINE_PCI_DEVICE_TABLE macro with explicit structure declarations, which permits the code to compile

Comment 5 Larry the Git Cow gentoo-dev

2019-12-05 19:08:50 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4920ae914fbced2306443df626c070e239315acb

commit 4920ae914fbced2306443df626c070e239315acb
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-12-05 19:04:24 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-12-05 19:08:45 +0000

    package.mask: Last rite app-laptop/nvidiabl
    
    Bug: https://bugs.gentoo.org/602024
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask | 6 ++++++
 1 file changed, 6 insertions(+)