Bug 601792

Summary:	net-misc/rsync-3.1.2 request for rsyncd.socket file for systemd socket activation
Product:	Gentoo Linux	Reporter:	Michael Jones <gentoo>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	UNCONFIRMED ---
Severity:	normal	CC:	christo.kotsi, systemd
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	rsync-3.1.2.ebuild.patch rsyncd@.service rsyncd.socket rsync-3.1.2.ebuild.patch rsync-3.1.2.ebuild.patch rsyncd-service rsync-3.1.2.ebuild.patch

Description Michael Jones 2016-12-06 08:40:50 UTC

Being able to launch the rsync daemon based on incoming socket activity would be a nice feature for system administrators that choose to use systemd.

Fedora offers an illustrative rsyncd.socket file in their rsync package

http://pkgs.fedoraproject.org/cgit/rpms/rsync.git/tree/rsyncd.socket?id=4f455260f4daf71946fd9a88f2356cb25399d642

[Unit]
Description=Rsync Server Socket
Conflicts=rsyncd.service

[Socket]
ListenStream=873
Accept=yes

[Install]
WantedBy=sockets.target

Comment 1 christos kotsis 2017-04-10 14:14:41 UTC

Created attachment 469588 [details, diff]
rsync-3.1.2.ebuild.patch

Comment 2 christos kotsis 2017-04-10 14:15:24 UTC

Created attachment 469590 [details, diff]
rsyncd@.service

Comment 3 christos kotsis 2017-04-10 14:15:59 UTC

Created attachment 469592 [details, diff]
rsyncd.socket

Comment 4 christos kotsis 2017-04-10 15:02:10 UTC

Created attachment 469596 [details, diff]
rsync-3.1.2.ebuild.patch

Comment 5 christos kotsis 2017-04-10 15:51:37 UTC

Created attachment 469600 [details, diff]
rsync-3.1.2.ebuild.patch

Comment 6 christos kotsis 2017-04-10 16:37:02 UTC

Created attachment 469602 [details, diff]
rsyncd-service

Comment 7 christos kotsis 2017-04-10 16:38:54 UTC

Created attachment 469604 [details, diff]
rsync-3.1.2.ebuild.patch

Comment 8 Michael Jones 2017-04-25 21:16:25 UTC

Why 
+	if [[ -e "/etc/systemd/system/" ]]; then
+		insinto /etc/
+		insinto /etc/systemd/system/
+		newins "${FILESDIR}"/rsyncd.socket rsyncd.socket
+		newins "${FILESDIR}"/rsyncd-service rsyncd@.service
+	else
+		dodir /etc/systemd/system/
+		insinto /etc/
+		insinto /etc/systemd/system/
+		newins "${FILESDIR}"/rsyncd.socket rsyncd.socket
+		newins "${FILESDIR}"/rsyncd-service rsyncd@.service
+	fi

When you could do

+	if [[ ! -e "/etc/systemd/system/" ]]; then
+		dodir /etc/systemd/system/
+       fi
+	insinto /etc/systemd/system/
+	newins "${FILESDIR}"/rsyncd.socket rsyncd.socket
+	newins "${FILESDIR}"/rsyncd-service rsyncd@.service


?

Comment 9 Michael Jones 2021-05-14 06:07:48 UTC

Any maintainers feel like picking up the provided patch?

It's been quite a long time since I opened this issue.