Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 600968

Summary: =sys-apps/portage-2.3.0: duplicate description src_unpack/src_prepare in man 5 ebuild
Product: Portage Development Reporter: Sergey S. Starikoff <Ikonta>
Component: DocumentationAssignee: Portage team <dev-portage>
Status: CONFIRMED ---    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Sergey S. Starikoff 2016-11-27 09:24:49 UTC
Reminding ebuild write skills in man 5 ebuild I was a little bit confused:

man 5 ebuild:
…
       src_unpack
              This function is used to unpack all the sources in A to WORKDIR.  If not defined in the ebuild script
              it calls unpack ${A}. Any patches and other pre configure/compile modifications should be done here.
              Initial working directory: $WORKDIR

       src_prepare
              All preparation of source code, such as application of patches, should be done here. This function is
              supported beginning with EAPI 2.
              Initial working directory: $S
…


Probably src_unpack description should contain notes, that applying patches here should be done only whe using legacy EAPI 0 or EAPI 1. Or completely remove note about applying patches on this phase.

Excuse me my English, that is why I don't suggest patch.