Summary: | www-client/jd-2.8.5_p120826 : /.../drawareabase.h:309:51: error: cannot convert ‘Glib::RefPtr<Gdk::Window>’ to ‘const bool’ in return | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | CJK Team <cjk> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | slawomir.nizio |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 536984, 582084 | ||
Attachments: |
config.log
emerge-history.txt environment www-client:jd-2.8.5_p120826:20161125-103429.log explicitly cast Glib::RefPtr to bool |
Description
Toralf Förster
2016-11-25 13:28:17 UTC
Created attachment 454328 [details]
config.log
Created attachment 454330 [details]
emerge-history.txt
Created attachment 454332 [details]
environment
Created attachment 454334 [details]
www-client:jd-2.8.5_p120826:20161125-103429.log
The error appears to happen because Glib::RefPtr no longer implicitly converts to bool with gcc 5. A simple solution is to explicitly cast it. I've attached a simple patch demonstrating the solution and confirmed that both the version in portage and the latest svn version compile with gcc-5.4.0 A few words of warning: 1. The portage version JD is outdated and no longer works (segfaults) with some external textboards. 2. JDs main use case is to browse 2channel, but because of change in API and policy of the 2channel board, JD can no longer be used with it without major user intervention, like setting up a local proxy to scrape the html version of 2channel and convert it to a format JD understands. 3. Because of the previously mentioned change of 2channel policy, the author of JD stated that the requirements to use the new API are incompatible with open source, therefore there is very little chance JD will work with 2channel again. Development also seems to have stopped. 4. JD is still fully usable with other boards, but for some of them a newer version than what is available in portage is needed. Created attachment 471340 [details, diff]
explicitly cast Glib::RefPtr to bool
this still happens with gcc6 too The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d93be79561a120db88087a6ebe1733ad98041c5a commit d93be79561a120db88087a6ebe1733ad98041c5a Author: Akinori Hattori <hattya@gentoo.org> AuthorDate: 2018-08-06 12:47:08 +0000 Commit: Akinori Hattori <hattya@gentoo.org> CommitDate: 2018-08-06 12:47:08 +0000 www-client/jd: fix build with >=sys-devel/gcc-5 Closes: https://bugs.gentoo.org/600802 Package-Manager: Portage-2.3.40, Repoman-2.3.9 www-client/jd/files/jd-gcc-5.patch | 15 +++++++++++++++ www-client/jd/jd-2.8.5_p120826.ebuild | 2 ++ 2 files changed, 17 insertions(+) |