Bug 600266

Summary:	net-analyzer/bro-2.4.1 invalid python hashbang
Product:	Gentoo Linux	Reporter:	Alessandro Molari <molari.alessandro>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jstein, kalin, molari.alessandro
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/8107
Whiteboard:
Package list:		Runtime testing required:	---

Description Alessandro Molari 2016-11-20 10:12:15 UTC

The bro scripts are using a wrong hashbang.

For example, when I try to start broctl I get:

/usr/bin/broctl: bad interpreter: /var/tmp/portage/net-analyzer/bro-2.4.1-r2/temp/python2.7/bin/

Another example is, after manually hotfixing the hashbang, when I start broctl and I try to run the command 'deploy'


Reproducible: Always

Steps to Reproduce:
1. Add broctl use flag
2. Run broctl
Actual Results:  
/usr/bin/broctl: bad interpreter: /var/tmp/portage/net-analyzer/bro-2.4.1-r2/temp/python2.7/bin/

Expected Results:  
broctl should start without errors

Comment 1 Larry the Git Cow gentoo-dev

2018-05-01 09:26:48 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c1fecceec0e9a6dd1880120a40d59bad0cf56523

commit c1fecceec0e9a6dd1880120a40d59bad0cf56523
Author:     Horea Christian <horea.christ@yandex.com>
AuthorDate: 2018-04-22 15:33:58 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-05-01 09:26:38 +0000

    net-analyzer/bro: fix python shebang #600266
    
    Package-Manager: Portage-2.3.31, Repoman-2.3.9
    Closes: https://bugs.gentoo.org/600266
    Closes: https://github.com/gentoo/gentoo/pull/8107

 net-analyzer/bro/bro-2.4.1-r2.ebuild | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comment 2 Kalin KOZHUHAROV 2018-05-15 00:10:35 UTC

I am afraid this fix broke too many things in the package :-|
(I was using another ebuild from own overlay, so I missed it till now)

Basically, it smashes all scripts to be run via the python interpreter, while in fact most are bash scripts. Here is the situation after `emerge =net-analyzer/bro-2.4.1-r2::gentoo` for me:
$ file /usr/share/broctl/scripts/*
/usr/share/broctl/scripts/archive-log:       Python script, ASCII text executable
/usr/share/broctl/scripts/broctl-config.sh:  broken symbolic link to /var/spool/bro//broctl-config.sh
/usr/share/broctl/scripts/cflow-stats:       Python script, ASCII text executable
/usr/share/broctl/scripts/check-config:      Python script, ASCII text executable
/usr/share/broctl/scripts/crash-diag:        Python script, ASCII text executable
...

while looking at the source they all (except `stats-to-csv`) are bash scripts indeed. As you might guess it makes it more unusable than before.

I am not sure what is the best course of action, given the maintainer-needed status of the package, but probably reverting that change is better (and reopening the bug).

I am considering stepping up as a proxy-maintainer and am working on latest bro-2.5.3 in the moment (that is why I found the issue). BTW, in 2.5.3 this bug is not present, AFAICS.