| Summary: | >=net-misc/nextcloud-client-2.2.4 USE=dolphin does not integrate with dolphin | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Felix Tiede <info> |
| Component: | Current packages | Assignee: | Bernard Cafarelli <voyageur> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | AMD64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Integrate nextcloud-client's dolphin plugin correctly.
General OEM theming patch |
||
Created attachment 453772 [details, diff]
General OEM theming patch
This new patch correctly integrates OEM theming with the dolphin plugin and is applicable to net-misc/owncloud-client as well without changing functionality.
The patch is tested against net-misc/nextcloud-client-2.2.4-r1 and net-misc/owncloud-client-2.2.4 and works as expected. A corresponding pull-request upstream showed no conflict with owncloud-client master branch.
Thanks for the report and patch! As it is in the owncloud code itself, yes I am not sure how upstream can go with it. But I can add this downstream in the meantime Added in -r2, thanks for the patch! Merged into upstream master branch (net-misc/owncloud-client and thus also into net-misc/nextcloud-client). No idea when it will be released, though. Thanks for the update and pushing this upstream! At least Gentoo users have this fixed in current ebuild until a new release |
Created attachment 453670 [details, diff] Integrate nextcloud-client's dolphin plugin correctly. Despite the service libraries being built and installed, the usual context menu actions as known from net-misc/owncloud-client do not appear. This is an issue with the client theming which generates libraries named after the theme in use but does not take these names into account when installing the necessary .desktop files. I don't know if this can or will be fixed upstream, as the binaries and their generation are entirely in the hands of ownCloud, while the the problem does only appear with a themed client using different binary names (which, in this case, is Nextcloud's part). The attached quick'n'dirty patch solves the problem downstream by modifying the .desktop file after unpacking all upstream components. It is no patch to be used generally but only for the current Nextcloud theme.