Bug 599690

Summary:	net-wireless/blueberry: New Package: A Bluetooth configuration tool
Product:	Gentoo Linux	Reporter:	laurantino <olivier.laurantin>
Component:	New packages	Assignee:	Proxy Maintainers <proxy-maint>
Status:	RESOLVED FIXED
Severity:	normal	CC:	cinnamon+disabled, k_f, olivier.laurantin
Priority:	Normal	Keywords:	EBUILD
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/linuxmint/blueberry
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	600236
Attachments:	blueberry-1.1.8.ebuild blueberry-1.1.8.ebuild blueberry-1.1.8.ebuild metadata.xml

Description laurantino 2016-11-14 07:12:32 UTC

In the gnome-extra/cinnamon ebuild, bluetooth has been disabled because of problems with cinnamon-bluetooth. Upstream is now using blueberry to interact with gnome-bluetooth (>=3.14).

Reproducible: Always

Comment 1 laurantino 2016-11-14 07:14:28 UTC

Created attachment 453266 [details]
blueberry-1.1.8.ebuild

I attach an ebuild I wrote for the latest version of blueberry.

Comment 2 Kristian Fiskerstrand (RETIRED) gentoo-dev

2016-11-14 11:17:11 UTC

(In reply to charlot from comment #1)
> Created attachment 453266 [details]
> blueberry-1.1.8.ebuild
> 
> I attach an ebuild I wrote for the latest version of blueberry.

As discussed in email will look at it for possibility of proxied maintenance.

Comment 3 Kristian Fiskerstrand (RETIRED) gentoo-dev

2016-11-14 19:22:42 UTC

(i) Are you sure this only works with python 2.7? 
(ii) src_prepare should include epatch_user (in eutils , already inherited)
(iii) package includes a Makefile, any reason for not just using the default src_compile() ?
(iv) Following on (iii), why do specific install instruction, isn't this covered in the Makefile?

Comment 4 laurantino 2016-11-15 07:15:46 UTC

(i) Are you sure this only works with python 2.7?

Yes, I just checked by myself to be sure!

(ii) src_prepare should include epatch_user (in eutils , already inherited)

OK

(iii) package includes a Makefile, any reason for not just using the default src_compile() ?

The src_compile part is indeed not necessary, I'll remove it

(iv) Following on (iii), why do specific install instruction, isn't this covered in the Makefile?

The Makefile just deals with building language files, it doesn't install anything, we have to it by ourselves

Comment 5 laurantino 2016-11-15 07:16:49 UTC

Created attachment 453344 [details]
blueberry-1.1.8.ebuild

Modified version of the ebuild

Comment 6 Kristian Fiskerstrand (RETIRED) gentoo-dev

2016-11-18 23:51:24 UTC

(In reply to charlot from comment #5)
> Created attachment 453344 [details]
> blueberry-1.1.8.ebuild
> 
> Modified version of the ebuild


Ebuild looks fine for me. If you want to be proxied maintainer for this package, can you also provide a metadata.xml in the style of https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/User_Guide#How_proxy_maintainership_works ?

Comment 7 laurantino 2016-11-19 07:15:09 UTC

Created attachment 453762 [details]
blueberry-1.1.8.ebuild

Add missing x11-misc/wmctrl dependency

Comment 8 laurantino 2016-11-19 07:16:27 UTC

Created attachment 453764 [details]
metadata.xml

Comment 9 Kristian Fiskerstrand (RETIRED) gentoo-dev

2016-11-19 16:07:18 UTC

Thanks and congratulations on becomming a proxied maintainer. If you have any questions, feel free to contact us on IRC in #gentoo-proxy-maint on FreeNode or use the gentoo-proxy-maint@lists.gentoo.org mailing list.

Your Maintainer bug for tracking Gentoo activity is bug 600236, please announce it here if your involvement in Gentoo were to change, or if you have any other requests such as wanting to become a full developer.

commit 5df1b83896bc3231c4fd933fada4cf186193a7c1
Author: Kristian Fiskerstrand <k_f@gentoo.org>
Date:   Sat Nov 19 17:03:02 2016 +0100

    net-wireless/blueberry: New package
    
    Proxied maintained c.f
    Gentoo-Bug: 600236
    Gentoo-Bug: 599690
    
    Package-Manager: portage-2.3.2