Bug 598430

Summary:	kde-apps/krfb-16.08.2: fails to build w/ gcc-6
Product:	Gentoo Linux	Reporter:	Jonathan Scruggs (RETIRED) <dracwyrm>
Component:	Current packages	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dracwyrm, jstein, mike
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:	fixed in 16.12
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	582084
Attachments:	krfb-16.08.2-fix-build-by-undefining-max-macro.patch krfb-16.08.2-r1.ebuild

Description Jonathan Scruggs (RETIRED) gentoo-dev

2016-10-29 12:11:43 UTC

Created attachment 451834 [details, diff]
krfb-16.08.2-fix-build-by-undefining-max-macro.patch

Attached is a patch that is in official upstream master repository. It's not in the 16.08 branch so I'm guessing it will not be released in a point release. This is the official fix to this bug: https://bugs.gentoo.org/show_bug.cgi?id=582954

Patching libvncserver with that patch may cause future incompatibilities with the next release of krfb; the above mentioned bug report can thus be closed. I have tested this with gcc 6.2.0-r1 recompiling both libvncserver and krfb.

Comment 1 Jonathan Scruggs (RETIRED) gentoo-dev

2016-10-29 12:14:41 UTC

Created attachment 451838 [details]
krfb-16.08.2-r1.ebuild

Ebuild I used to test the patch.

I found out the hard way that kde apps don't use user patches in /etc/portage/patches even though it's EAPI 6. Bug or on purpose?

Comment 2 Jonathan Scruggs (RETIRED) gentoo-dev

2016-10-29 12:21:12 UTC

Correction. I just noticed that libvncserver upstream has that other patch in the above bug report in their master branch: https://github.com/LibVNC/libvncserver/commit/53cc1fa18a3b96d2c31a145d971017564fca39bb

This will be interesting to see how these two programs interact with each other as they both did different fixes.

Comment 3 Johannes Huber (RETIRED) gentoo-dev

2016-11-15 20:08:42 UTC

Thanks.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e805750640ffcd5150e817e77162f388021b8c0f

Comment 4 Johannes Huber (RETIRED) gentoo-dev

2016-11-15 20:09:14 UTC

(In reply to Johannes Huber from comment #3)
> Thanks.
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=e805750640ffcd5150e817e77162f388021b8c0f

Sorry, wrong bug.

Comment 5 Mike Lothian 2016-11-30 14:22:28 UTC

This fix is also needed for 16.08.3

Comment 6 devsk 2016-12-13 07:02:04 UTC

Is this going to be added to 16.08.3 version?

Comment 7 Andreas Sturmlechner gentoo-dev

2016-12-13 10:01:30 UTC

I suspect rather than that, Applications release 16.12 should arrive in a few days.

Comment 8 Johannes Huber (RETIRED) gentoo-dev

2016-12-16 18:46:15 UTC

Thanks.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=31645664f42a588800ba68febd89a9c9e6afc76f