Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 597914

Summary: net-dns/dnscrypt-proxy - initscript contains bashism
Product: Gentoo Linux Reporter: Hadrien Lacour <hadrien.lacour>
Component: Current packagesAssignee: Georgy Yakovlev <gyakovlev>
Status: RESOLVED FIXED    
Severity: normal CC: dlan, openrc, polynomial-c
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 609070    
Attachments: dnscrypt-proxy.initd-1.6.1 bashism patch

Description Hadrien Lacour 2016-10-23 20:07:04 UTC
Created attachment 451210 [details, diff]
dnscrypt-proxy.initd-1.6.1 bashism patch

The package file "dnscrypt-proxy.initd-1.6.1" contains a superfluous "[[ == ]]" that I, as a /bin/sh -> /bin/dash user, had to edit.

Included the (trivial) patch.
Comment 1 Yixun Lan archtester gentoo-dev 2016-10-30 22:46:12 UTC
I'm not sure if bash is the essential requirement for OpenRC init script, and possible change to make it dash compatible, so CC them
Comment 2 Hadrien Lacour 2016-10-30 23:14:41 UTC
https://wiki.gentoo.org/wiki/OpenRC/Baselayout_1_to_2_migration
>This led to a development of baselayout 2, which is written in C and only requires a POSIX-compliant shell
Comment 3 Yixun Lan archtester gentoo-dev 2016-10-31 04:26:49 UTC
thanks, Hadrien Lacour

I've already realized that OpenRC require POSIX sh compatible..
I'm reviewing bug 588462, and probably we will merge your patch together in next revision bump
Comment 4 Georgy Yakovlev archtester gentoo-dev 2017-11-19 02:50:35 UTC
The bug has been closed in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0ee515fb8a5ff324983ec37c38ec1e2dc8d7aaa6

commit 0ee515fb8a5ff324983ec37c38ec1e2dc8d7aaa6
Author:     Georgy Yakovlev <ya@sysdump.net>
AuthorDate: 2017-08-07 20:52:14 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2017-11-07 08:48:03 +0000