Summary: | sys-apps/portage should do URL escaping when fetching binpkgs | ||
---|---|---|---|
Product: | Portage Development | Reporter: | MCassaniti <michael> |
Component: | Binary packages support | Assignee: | Portage team <dev-portage> |
Status: | UNCONFIRMED --- | ||
Severity: | normal | CC: | jstein, michael, ulm |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=598380 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
MCassaniti
2016-10-21 01:41:17 UTC
This isn't just limited to dvd+rw-tools, although that does make the bug easier to understand. I've had the issue with gtk+ packages too. I'm not sure if the URL encoding should be done by default. If that is the case then the change is trivial to implement. Adjusting the summary to address the binpkg aspect. SRC_URI is being addressed via bug 598380. IMHO, Portage should leave URIs alone. If we encode "+" as "%2B" then how would one pass a literal plus sign? Note that RFC 3986 defines "+" (amongst other characters) as a sub-delimiter, in order "to provide a set of delimiting characters that are distinguishable from other data within a URI". Maybe it is clearer for "/" which is also a reserved character. You only encode it as "%2F" if you *don't* want it to act as a delimiter. (In reply to MCassaniti from comment #0) > https://s3.amazonaws.com/mybucket/app-cdr/dvd+rw-tools-7.1-r1.tbz2 > Resolving s3.amazonaws.com... 52.216.64.51 > Connecting to s3.amazonaws.com|52.216.64.51|:443... connected. > HTTP request sent, awaiting response... 403 Forbidden > https://s3.amazonaws.com/mybucket/app-cdr/dvd%2Brw-tools-7.1-r1.tbz2 > Resolving s3.amazonaws.com... 52.216.65.51 > Connecting to s3.amazonaws.com|52.216.65.51|:443... connected. > HTTP request sent, awaiting response... 200 OK > [...] As one can see, the 403 and 200 responses are generated on the server side. |