Bug 596996 – net-libs/webkit-gtk: $(tc-getCXX) == *g++* matches 'clang++'

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Sergey 'L29Ah' Alirzaev 2016-10-12 20:16:37 UTC]

So the version check will fail.

[Comment 1 Pacho Ramos 2016-10-15 08:48:33 UTC]

And gcc-version is also matching clang? (both conditions must be fulfilled)

[Comment 2 Sergey 'L29Ah' Alirzaev 2016-10-15 11:45:58 UTC]

It reports clang's version (3.8.1).

[Comment 3 Pacho Ramos 2016-10-15 11:49:51 UTC]

We should then try to use tc-is-gcc from toolchain-funcs.eclass instead of grepping I guess :/

[Comment 4 Franz Trischberger 2016-10-21 08:35:32 UTC]

The following patch makes checks succeed with clang-3.9.0 and gcc-4.9.3:

diff --git a/net-libs/webkit-gtk/webkit-gtk-2.12.5.ebuild b/net-libs/webkit-gtk/webkit-gtk-2.12.5.ebuild
index 0883498..fd97969 100644
--- a/net-libs/webkit-gtk/webkit-gtk-2.12.5.ebuild
+++ b/net-libs/webkit-gtk/webkit-gtk-2.12.5.ebuild
@@ -131,7 +131,7 @@ pkg_pretend() {
                        die "You need at least GCC 4.9.x or Clang >= 3.3 for C++11-specific compiler flags"
                fi

-               if [[ $(tc-getCXX) == *g++* && $(gcc-version) < 4.9 ]] ; then
+               if [[ $(tc-is-gcc) && $(gcc-version) < 4.9 ]] ; then
                        die 'The active compiler needs to be gcc 4.9 (or newer)'
                fi
        fi

[Comment 5 Gilles Dartiguelongue (RETIRED) 2016-10-30 10:13:59 UTC]

FTR, this is implemented in masked webkit-gtk-2.14

[Comment 6 Gilles Dartiguelongue (RETIRED) 2016-11-12 15:06:02 UTC]

Fixed ebuild is now unmasked. Thanks for reporting.