Bug 596680

Summary:	games-strategy/freeorion-0.4.6 version bump
Product:	Gentoo Linux	Reporter:	Bernd Pachur <gentoo>
Component:	Current packages	Assignee:	Adam Feldman <np-hardass>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kripton, tomka
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	ebuild boost patch for 0.4.6 ebuild

Description Bernd Pachur 2016-10-09 12:19:31 UTC

0.4.6 (not -pre) is out.

Reproducible: Always

Comment 1 Bernd Pachur 2016-10-16 07:53:54 UTC

Created attachment 450348 [details]
ebuild

modified copy of the 0.4.5-r1 ebuild
needs the updated boost patch!

Comment 2 Bernd Pachur 2016-10-16 07:55:05 UTC

Created attachment 450350 [details, diff]
boost patch for 0.4.6 ebuild

patch for 0.4.6 ebuild to allow build with boost >= 1.6.1

Comment 3 Thomas Kahle (RETIRED) gentoo-dev

2016-10-21 20:45:51 UTC

np-hardass took over maintainership.
Thanks!

Comment 4 anthorx 2017-03-15 07:15:45 UTC

Why isn't the update already merged? I don't see any pull requests on GitHub.

Comment 5 Adam Feldman gentoo-dev

2017-03-16 04:29:22 UTC

Resolved in bed9b713e4365156fa6193cfdaf2940b773c0980.

Thanks for the submission Bernd.  I ended up working this one myself because I needed to convert it away from the games eclass and thought it simpler to do that myself rather than imposing that on you, someone just kind enough to submit a patch.

Recommendation for submitting future patches: Usually, it's better to submit a diff rather than the full ebuild so I can see what you've specifically changed.  Additionally, when submitting a patch to fix a build issue, usually it is better to submit upstream and then backport their patch (and keeping the metadata so that the origins of the patch can be tracked)

Anyways, thanks again for the submission.  Looking forward to more from you in the future.