Summary: | publib-0.31.ebuild (New Package) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ilian Zarov <coder> |
Component: | New packages | Assignee: | chouser (RETIRED) <chouser> |
Status: | VERIFIED FIXED | ||
Severity: | enhancement | CC: | coder |
Priority: | High | ||
Version: | 1.0 RC6 r14 | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | publib-0.31.ebuild |
Description
Ilian Zarov
2002-02-07 20:06:12 UTC
Created attachment 141 [details]
publib-0.31.ebuild
Are there any problems with this ebuild ? If so, please contact me. Sorry for the delay -- it was simply due to the number of items ahead of this ebuild in my work list, not because of anything in the ebuild itself. Here are my comments, made as I went through and tested each part of the ebuild. Please don't take them personally. :-) I reworded the DESCRIPTION to try to pack more info into the one line. I think I found the "home page" and primary location of the source, but it wasn't easy. Thanks for digging out such an obscure package -- I'm sure it will prove useful! Anyway, I adjusted the SRC_URI and added a HOMEPAGE. The version number in the SRC_URI shouldn't be hardcoded -- use ${PV} or ${P} allows the URI to be calculated based on the ebuild file name. cd ${S} isn't needed anymore, and this package doesn't need the --infodir line. I added more error messages to some "die" lines. They're not required, but I like verbose error messages. I added some dodoc lines to install various little text files from around the source tree. The make install mandir should be ${D}/usr/share/man, not ${D}/usr/man -- same for the mkdir commands. The debian package also renames all the "foo.3" man pages to "foo.3pub" instead. This is good, because otherwise we would overwrite existing man pages (like /usr/share/man/man3/hash.3). If we name them "foo.o" and put them in the mano directory, then the man command can find them with the default /etc/man.conf. If this isn't acceptable, we may have to find some other solution later (like creating a new man3pub dir and adding it to /etc/man.conf) All fixed up and submitted to CVS. Thanks for contributing! Thanks for the thorough comments. I guess I overlooked the man pages extention in the output. P.S. Why did you remove the author line ? By the way, it would be a good idea an Author line to contain two (or more) names or a separate line (e.g. Original Author and Modifications by) :). We used to have Author and Maintainer lines in the ebuild, but both of these have been deprecated in favor of listing the details in the ChangeLog. If you look there, you will see your name for the initial ebuild, as well as mine the changes I made. --Chouser |