Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 595880

Summary: repoman should warn when the same dependency is specified multiple times in *DEPEND
Product: Portage Development Reporter: Pacho Ramos <pacho>
Component: RepomanAssignee: Portage team <dev-portage>
Status: RESOLVED WONTFIX    
Severity: enhancement CC: floppym
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Pacho Ramos gentoo-dev 2016-10-02 09:00:41 UTC
I have just seen one ebuild that was setting exactly the same dev-libs/libpcre in the same DEPEND=() chunk.

Maybe repoman could warn when this mistake is done

Thanks a lot!
Comment 1 Mike Gilbert gentoo-dev 2016-10-02 13:22:58 UTC
Why? That should not cause any problem in dependency resolution.
Comment 2 Pacho Ramos gentoo-dev 2016-10-02 13:30:29 UTC
Well, for having more tidy ebuilds... a bit like the warning about trailing spaces in ebuilds
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-10-02 13:38:12 UTC
If we do something like this, we need to ensure the check occurs before USE conditionals are removed (otherwise dep needed by two or more USE flags separately would trigger this).

However, I think this would work as well if we encourage developers to sort dependencies.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:33 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.