Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 595296

Summary: app-crypt/gpgme-1.7.0: on x86: #error GPGME was compiled with _FILE_OFFSET_BITS = 64 [...]
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Crypto team [DISABLED] <crypto+disabled>
Status: RESOLVED FIXED    
Severity: normal CC: alonbl, thanasis
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=847955
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 471102    
Attachments: app-crypt:gpgme-1.7.0:20160927-164911.log

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-09-27 16:59:47 UTC
Created attachment 448132 [details]
app-crypt:gpgme-1.7.0:20160927-164911.log

In file included from callbacks.h:29:0,
                 from callbacks.cpp:23:
../../../src/gpgme.h:104:2: error: #error GPGME was compiled with _FILE_OFFSET_BITS = 64, please see the section "Largefile support (LFS)" in the GPGME manual.
#error GPGME was compiled with _FILE_OFFSET_BITS = 64, please see the section "Largefile support (LFS)" in the GPGME manual.
 ^
Comment 1 Kristian Fiskerstrand (RETIRED) gentoo-dev 2016-09-27 17:09:49 UTC
This is upstream issue https://lists.gnupg.org/pipermail/gnupg-devel/2016-September/031660.html should be fixed in upstream git commits 538ab40a and 3703a472
Comment 2 Alon Bar-Lev (RETIRED) gentoo-dev 2016-10-03 18:33:40 UTC
Hi,
Could not find these commits, but a142f187b should solve this.
Please check this out.
Thanks!
Comment 3 thanasis 2016-10-07 08:25:32 UTC
I still have this bug.
Why did you mark it as fixed?
Comment 4 Alon Bar-Lev (RETIRED) gentoo-dev 2016-10-07 08:36:08 UTC
(In reply to thanasis from comment #3)
> I still have this bug.
> Why did you mark it as fixed?

because I've added the patch that should have fixed it. if it is not fixed we will wait for the next version.
Comment 5 thanasis 2016-10-09 10:35:58 UTC
(In reply to Alon Bar-Lev from comment #4)
> (In reply to thanasis from comment #3)
> > I still have this bug.
> > Why did you mark it as fixed?
> 
> because I've added the patch that should have fixed it. if it is not fixed
> we will wait for the next version.

I don't see any patch here... Where is that patch you have added?
Comment 6 Alon Bar-Lev (RETIRED) gentoo-dev 2016-10-09 11:03:34 UTC
(In reply to thanasis from comment #5)
> (In reply to Alon Bar-Lev from comment #4)
> > (In reply to thanasis from comment #3)
> > > I still have this bug.
> > > Why did you mark it as fixed?
> > 
> > because I've added the patch that should have fixed it. if it is not fixed
> > we will wait for the next version.
> 
> I don't see any patch here... Where is that patch you have added?

https://gitweb.gentoo.org/repo/gentoo.git/tree/app-crypt/gpgme/gpgme-1.7.0.ebuild#n45
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-10-09 11:22:31 UTC
PMS note: you aren't allowed to refer to ${T} in global scope (PATCHES).
Comment 8 Alon Bar-Lev (RETIRED) gentoo-dev 2016-10-09 11:26:28 UTC
(In reply to Michał Górny from comment #7)
> PMS note: you aren't allowed to refer to ${T} in global scope (PATCHES).

oh... I wounder why DISTDIR, WORKDIR are ok and T not... :)
shouldn't repoman warn?
I will fix that.
Comment 9 thanasis 2016-10-17 10:24:53 UTC
(In reply to Alon Bar-Lev from comment #6)
> https://gitweb.gentoo.org/repo/gentoo.git/tree/app-crypt/gpgme/gpgme-1.7.0.
> ebuild#n45

Still the same error, even with above ebuild.
Comment 10 Alon Bar-Lev (RETIRED) gentoo-dev 2016-10-17 20:12:52 UTC
(In reply to thanasis from comment #9)
> (In reply to Alon Bar-Lev from comment #6)
> > https://gitweb.gentoo.org/repo/gentoo.git/tree/app-crypt/gpgme/gpgme-1.7.0.
> > ebuild#n45
> 
> Still the same error, even with above ebuild.

We will wait for next release.
For now, you can probably checkout the git head.
Comment 11 thanasis 2016-10-18 11:48:29 UTC
(In reply to Alon Bar-Lev from comment #10)
> (In reply to thanasis from comment #9)
> > (In reply to Alon Bar-Lev from comment #6)
> > > https://gitweb.gentoo.org/repo/gentoo.git/tree/app-crypt/gpgme/gpgme-1.7.0.
> > > ebuild#n45
> > 
> > Still the same error, even with above ebuild.
> 
> We will wait for next release.
> For now, you can probably checkout the git head.

...and what makes us think that the next release would not suffer the same bug?
Comment 12 Kristian Fiskerstrand (RETIRED) gentoo-dev 2016-10-18 11:59:05 UTC
(In reply to thanasis from comment #11)
> (In reply to Alon Bar-Lev from comment #10)
> > (In reply to thanasis from comment #9)
> > > (In reply to Alon Bar-Lev from comment #6)
> > > > https://gitweb.gentoo.org/repo/gentoo.git/tree/app-crypt/gpgme/gpgme-1.7.0.
> > > > ebuild#n45
> > > 
> > > Still the same error, even with above ebuild.
> > 
> > We will wait for next release.
> > For now, you can probably checkout the git head.
> 
> ...and what makes us think that the next release would not suffer the same
> bug?

commit a142f187b7ddb2728ec3e1743da4a0c4538ab40a
Author: Andre Heinecke <aheinecke@intevation.de>
Date:   Fri Sep 23 15:22:29 2016 +0200

...
    
    --
    This fixes problems with mismatching definitions. Most
    notably _FILE_OFFSET_BITS is now always set correctly.

commit 3703a4723899d7563937b4b99f5bbe4dd8d3dfed
Author: Justus Winter <justus@g10code.com>
Date:   Mon Sep 26 11:35:40 2016 +0200

...
    --
    Fixes build on 32 bit platforms with large file support.
    
    Signed-off-by: Justus Winter <justus@g10code.com>
Comment 13 Kristian Fiskerstrand (RETIRED) gentoo-dev 2016-10-18 12:14:42 UTC
(In reply to Kristian Fiskerstrand from comment #12)
> (In reply to thanasis from comment #11)
> > (In reply to Alon Bar-Lev from comment #10)
> > > (In reply to thanasis from comment #9)
> > > > (In reply to Alon Bar-Lev from comment #6)
> > > > > https://gitweb.gentoo.org/repo/gentoo.git/tree/app-crypt/gpgme/gpgme-1.7.0.
> > > > > ebuild#n45
> > > > 
> > > > Still the same error, even with above ebuild.
> > > 
> > > We will wait for next release.
> > > For now, you can probably checkout the git head.
> > 
> > ...and what makes us think that the next release would not suffer the same
> > bug?
> 
> commit a142f187b7ddb2728ec3e1743da4a0c4538ab40a
> Author: Andre Heinecke <aheinecke@intevation.de>
> Date:   Fri Sep 23 15:22:29 2016 +0200
> 

This is added already

> commit 3703a4723899d7563937b4b99f5bbe4dd8d3dfed
> Author: Justus Winter <justus@g10code.com>
> Date:   Mon Sep 26 11:35:40 2016 +0200
> 
> ...
>     --
>     Fixes build on 32 bit platforms with large file support.
>     
>     Signed-off-by: Justus Winter <justus@g10code.com>

This is missing
Comment 14 Kristian Fiskerstrand (RETIRED) gentoo-dev 2016-10-18 12:15:34 UTC
(In reply to thanasis from comment #11)
> (In reply to Alon Bar-Lev from comment #10)
> > (In reply to thanasis from comment #9)
> > > (In reply to Alon Bar-Lev from comment #6)
> > > > https://gitweb.gentoo.org/repo/gentoo.git/tree/app-crypt/gpgme/gpgme-1.7.0.
> > > > ebuild#n45
> > > 
> > > Still the same error, even with above ebuild.
> > 
> > We will wait for next release.
> > For now, you can probably checkout the git head.
> 
> ...and what makes us think that the next release would not suffer the same
> bug?

Can you try and see if it fixes your case if adding local patch with 3703a4723899d7563937b4b99f5bbe4dd8d3dfed ?
Comment 15 thanasis 2016-10-18 20:32:29 UTC
(In reply to Kristian Fiskerstrand from comment #14)
> Can you try and see if it fixes your case if adding local patch with
> 3703a4723899d7563937b4b99f5bbe4dd8d3dfed ?

How do I do that? (sorry I am not a developer...)
Comment 16 Kristian Fiskerstrand (RETIRED) gentoo-dev 2016-10-18 20:36:07 UTC
(In reply to thanasis from comment #15)
> (In reply to Kristian Fiskerstrand from comment #14)
> > Can you try and see if it fixes your case if adding local patch with
> > 3703a4723899d7563937b4b99f5bbe4dd8d3dfed ?
> 
> How do I do that? (sorry I am not a developer...)

As 1.7.1 that includes it got released today it is likely a bit moot to spend too much time on it in that case.
Comment 17 Kristian Fiskerstrand (RETIRED) gentoo-dev 2016-10-18 20:55:09 UTC
(In reply to Kristian Fiskerstrand from comment #16)
> (In reply to thanasis from comment #15)
> > (In reply to Kristian Fiskerstrand from comment #14)
> > > Can you try and see if it fixes your case if adding local patch with
> > > 3703a4723899d7563937b4b99f5bbe4dd8d3dfed ?
> > 
> > How do I do that? (sorry I am not a developer...)
> 
> As 1.7.1 that includes it got released today it is likely a bit moot to
> spend too much time on it in that case.

commit 5c5fccc039975f1af92d1043ced888450277077d
Author: Kristian Fiskerstrand <k_f@gentoo.org>
Date:   Tue Oct 18 22:54:17 2016 +0200

    app-crypt/gpgme: New upstream version 1.7.1
    
    New upstream version 1.7.1
    
    fixes:
    Gentoo-Bug: 595296
    
    Package-Manager: portage-2.3.1


closing, re-open if encountering the issue with the updated version
Comment 18 Alon Bar-Lev (RETIRED) gentoo-dev 2016-10-19 05:50:21 UTC
Cleaned it up a bit.
Comment 19 thanasis 2016-10-19 09:22:59 UTC
app-crypt/gpgme-1.7.1 built fine :)