Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 594878

Summary: media-plugins/gst-plugins-ffmpeg removal request
Product: Gentoo Linux Reporter: Pacho Ramos <pacho>
Component: Current packagesAssignee: GStreamer package maintainers <gstreamer>
Status: RESOLVED FIXED    
Severity: normal CC: candrews, fkrogh, jamesbroadhead, mgorny, mplichta, rich0, skrattaren, treecleaner
Priority: Normal Keywords: PMASKED
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/3309
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 594352, 594880, 594882, 594884, 601198    
Bug Blocks: 488276, 550648, 575056, 584038    
Deadline: 2017-03-18   

Description Pacho Ramos gentoo-dev 2016-09-23 16:01:06 UTC
Completely dead, also broken with ffmpeg-3, sooner or later we will need to kill it (as it will happen some day with gst-0.10 stuff) too
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2016-10-09 20:40:45 UTC
I propose we open a Gstreamer 0.10 removal tracker bug instead. It will give a clear signal we are seeking to actually removing it. We might not be able to do it in the short or mid term but other major distros are targetting this so we can probably achieve it too.
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2016-10-09 20:41:54 UTC
Ok that's bug #550648 actually.
Comment 3 Mart Raudsepp gentoo-dev 2016-12-05 14:33:16 UTC
The problem with gst-plugins-ffmpeg removal is that it makes 0.10 useless in various circumstances where a ffmpeg element is needed for any real functionality.
We should look into getting rid of the 0.10 consumers that rely on some ffmpeg/libav element for crucial functionality. That's mostly H.264 video I suppose. I guess we can drag on the rest a bit where it's for audio or other stuff or H.264 isn't crucial support to have.
If 0.10 removal can't be fast enough, we should at least try to get the stuff where it's useless without gst-plugins-ffmpeg removed/cleaned to move along outright removal. Though might not be worth the effort and just breaking these things to do anything useful in a H.264 dominant video world by gst-plugins-ffmpeg removal is fine.
Comment 4 Pacho Ramos gentoo-dev 2016-12-05 14:44:50 UTC
I would remove the plugin as soon as all the reverse deps with explicit depend on it are cleaned. For the remaining "hidden" reverse deps... well, that would be a good chance to finally catch them... this is exactly the pathway all other distributions have followed with gstreamer:0.10: they killed the ffmpeg plugin long time ago (as it's a hell to maintain), even if they are still providing apps relying on other gstreamer:0.10 stuff as, currently, is impossible to kill all gstreamer-0.10 consumers
Comment 5 Oleh 2016-12-07 14:10:25 UTC
is there a list of all gst-0.10 reverse deps? (that are in portage tree)
Comment 6 Fred Krogh 2016-12-07 15:34:09 UTC
This probably does not help, but it may give a better idea of the size of the problem.  On my machine equery l "gst*0.10* gives
[IP-] [  ] dev-python/gst-python-0.10.22-r1:0.10
[IP-] [  ] media-libs/gst-plugins-bad-0.10.23-r4:0.10
[IP-] [  ] media-libs/gst-plugins-base-0.10.36-r2:0.10
[IP-] [  ] media-libs/gst-plugins-good-0.10.31-r2:0.10
[IP-] [  ] media-libs/gst-plugins-ugly-0.10.19-r1:0.10
[IP-] [  ] media-libs/gstreamer-0.10.36-r2:0.10
[IP-] [  ] media-plugins/gst-plugins-a52dec-0.10.19-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-alsa-0.10.36-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-cdparanoia-0.10.36-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-dts-0.10.23-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-dvdread-0.10.19-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-faad-0.10.23-r2:0.10
[IP-] [  ] media-plugins/gst-plugins-flac-0.10.31-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-mad-0.10.19-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-meta-0.10-r10:0.10
[IP-] [  ] media-plugins/gst-plugins-mpeg2dec-0.10.19-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-ogg-0.10.36-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-pulse-0.10.31-r2:0.10
[IP-] [  ] media-plugins/gst-plugins-resindvd-0.10.23-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-theora-0.10.36-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-vorbis-0.10.36-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-x-0.10.36-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-x264-0.10.19-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-xvid-0.10.23-r1:0.10
[IP-] [  ] media-plugins/gst-plugins-xvideo-0.10.36-r1:0.10

I then did for x in `equery l "gst*0.10*"`;do equery d $x &>>gst-depend;done
and removed duplicates from gst-depend which gives
app-accessibility/orca-3.22.2
app-emulation/wine-1.9.20
app-office/libreoffice-5.2.3.3-r1
dev-perl/GStreamer-0.200.0
dev-perl/GStreamer-Interfaces-0.60.0-r1
dev-python/gst-python-0.10.22-r1
dev-python/gst-python-1.8.3
dev-qt/qtwebkit-4.8.7
dev-qt/qtwebkit-5.6.2
gnome-base/gnome-shell-3.22.2
mail-client/thunderbird-45.5.1
media-libs/clutter-gst-2.0.18
media-libs/clutter-gst-3.0.22
media-libs/cogl-1.22.2
media-libs/gst-plugins-bad-0.10.23-r4
media-libs/gst-plugins-bad-1.8.3-r1
media-libs/gst-plugins-base-0.10.36-r2
media-libs/gst-plugins-base-1.8.3-r1
media-libs/gst-plugins-good-0.10.31-r2
media-libs/gst-plugins-good-1.8.3
media-libs/gst-plugins-ugly-0.10.19-r1
media-libs/gst-plugins-ugly-1.8.3
media-libs/libcanberra-0.30-r5
media-plugins/grilo-plugins-0.3.3
media-plugins/gst-plugins-a52dec-0.10.19-r1
media-plugins/gst-plugins-a52dec-1.8.3
media-plugins/gst-plugins-alsa-0.10.36-r1
media-plugins/gst-plugins-cdparanoia-0.10.36-r1
media-plugins/gst-plugins-cdparanoia-1.8.3
media-plugins/gst-plugins-dts-0.10.23-r1
media-plugins/gst-plugins-dts-1.8.3
media-plugins/gst-plugins-dvdread-0.10.19-r1
media-plugins/gst-plugins-dvdread-1.8.3
media-plugins/gst-plugins-faad-0.10.23-r2
media-plugins/gst-plugins-faad-1.8.3
media-plugins/gst-plugins-flac-0.10.31-r1
media-plugins/gst-plugins-flac-1.8.3
media-plugins/gst-plugins-jpeg-1.8.3
media-plugins/gst-plugins-libav-1.8.3
media-plugins/gst-plugins-libnice-0.1.13-r100
media-plugins/gst-plugins-mad-0.10.19-r1
media-plugins/gst-plugins-mad-1.8.3
media-plugins/gst-plugins-meta-0.10-r10
media-plugins/gst-plugins-meta-1.8.3
media-plugins/gst-plugins-mpeg2dec-0.10.19-r1
media-plugins/gst-plugins-mpeg2dec-1.8.3
media-plugins/gst-plugins-ogg-0.10.36-r1
media-plugins/gst-plugins-pulse-0.10.31-r2
media-plugins/gst-plugins-pulse-1.8.3
media-plugins/gst-plugins-resindvd-0.10.23-r1
media-plugins/gst-plugins-resindvd-1.8.3
media-plugins/gst-plugins-soup-1.8.3
media-plugins/gst-plugins-taglib-1.8.3
media-plugins/gst-plugins-theora-0.10.36-r1
media-plugins/gst-plugins-v4l2-1.8.3
media-plugins/gst-plugins-vorbis-0.10.36-r1
media-plugins/gst-plugins-vpx-1.8.3
media-plugins/gst-plugins-x-0.10.36-r1
media-plugins/gst-plugins-x264-0.10.19-r1
media-plugins/gst-plugins-x264-1.8.3
media-plugins/gst-plugins-xvid-0.10.23-r1
media-plugins/gst-plugins-xvideo-0.10.36-r1
media-sound/exaile-3.4.5
media-sound/mp3splt-gtk-0.9.2-r1
media-video/cheese-3.22.1
media-video/totem-3.22.0
net-im/empathy-3.12.12
net-im/pidgin-2.11.0
net-libs/farstream-0.2.8-r1
net-libs/telepathy-farstream-0.6.2
net-libs/webkit-gtk-2.14.2
net-libs/webkit-gtk-2.4.11-r1
net-libs/webkit-gtk-2.4.11-r200
x11-libs/wxGTK-2.8.12.1-r2
x11-libs/wxGTK-3.0.2.0-r3
x11-libs/wxGTK-3.0.2.0-r301
xfce-extra/xfce4-mixer-4.11.0
xfce-extra/xfce4-volumed-0.1.13

This looks like a really big job!
Comment 7 Nikolaj Šujskij 2016-12-08 13:38:42 UTC
The only package depending on gstreamer 0.10 (incl. ffmpeg plugin) on my box is www-client/opera (v.12, ancient one), but I keep it mainly for mail.
Comment 8 Pacho Ramos gentoo-dev 2016-12-11 10:16:37 UTC
The general gst-0.10 removal is in bug #550648, this is only for the ffmpeg plugin
Comment 9 Mart Raudsepp gentoo-dev 2017-01-03 01:44:41 UTC
Looks like there are still versions of gnash that need this, old gst-plugins-meta slot needs this for something and bug 594352 for guayadeque
Comment 10 Richard Freeman gentoo-dev 2017-02-14 18:11:06 UTC
I added this as an ffmpeg-3 blocker (since it causes issues with upgrading to ffmpeg-3, which is now a security issue).  Differences in opinion on that are welcome, but I didn't just want to ignore the issue.
Comment 11 Mart Raudsepp gentoo-dev 2017-02-16 01:16:23 UTC
The compilation bug already had the blocker. Anyhow,

# Mart Raudsepp <leio@gentoo.org> (16 Feb 2017)
# Old gstreamer 0.10 version, which is security vulnerable.
# Use gstreamer:1.0 with media-plugins/gst-plugins-libav
# instead (despite the name, it uses media-video/ffmpeg too).
# Masked for removal in 30 days. Bug #594878
media-plugins/gst-plugins-ffmpeg
Comment 12 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-03-25 08:53:02 UTC
commit 0dc48181480c922e6a441502436646a64d729f7a
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: Sat Mar 25 09:30:24 2017
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: Sat Mar 25 09:44:27 2017

    media-plugins/gst-plugins-ffmpeg: Remove last-rited pkg, #594878
Comment 13 Mart Raudsepp gentoo-dev 2017-03-25 09:27:53 UTC
Package mask entry has to stay longer as there is no GLSA for gstreamer:0.10 out yet, and portage doesn't really complain properly about packages being installed that don't exist in repository yet without a p.mask entry

commit 6ecc945a673fcdc4f0cfc8f512c1fef198bfce12
Author: Mart Raudsepp <leio@gentoo.org>
Date:   Sat Mar 25 11:25:11 2017 +0200

    profiles: Add back gst-plugins-ffmpeg p.mask
    
    This partially reverts 0dc48181480c922e6a441502436646a64d729f7a